Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Apr 2017 12:55:46 +0200
From:      Koop Mast <kwm@FreeBSD.org>
To:        Jan Beich <jbeich@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r439206 - in head: deskutils/xfce4-notifyd games/lordsawar graphics/cairomm graphics/gdk-pixbuf2 graphics/gdk-pixbuf2/files x11-themes/adwaita-icon-theme x11-themes/gnome-themes-standar...
Message-ID:  <1493031346.1415.7.camel@FreeBSD.org>
In-Reply-To: <fugz-fpj4-wny@FreeBSD.org>
References:  <201704230835.v3N8ZSLg071205@repo.freebsd.org> <fugz-fpj4-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2017-04-23 at 11:21 +0200, Jan Beich wrote:
> Koop Mast <kwm@FreeBSD.org> writes:
> 
> > 
> > Author: kwm
> > Date: Sun Apr 23 08:35:28 2017
> > New Revision: 439206
> > URL: https://svnweb.freebsd.org/changeset/ports/439206
> > 
> > Log:
> >   Update the gtk+ stack [1]
> [...]
> > 
> > Index: x11-themes/gtk-arc-themes/Makefile
> > ===================================================================
> > --- x11-themes/gtk-arc-themes/Makefile	(revision 439205)
> > +++ x11-themes/gtk-arc-themes/Makefile	(revision 439206)
> > @@ -25,5 +25,6 @@ USES=		autoreconf pkgconfig
> >  GNU_CONFIGURE=	yes
> >  USE_GNOME=	gtk20 gtk30
> >  NO_ARCH=	yes
> > +CONFIGURE_ARGS=	--with-gnome=3.18
> Why not 3.20 after x11-toolkits/gtk30 > 3.18 update?

Hi,

Because gtk version != gnome version :) It defaults to the latest
released gnome version, which we don't have so we need to set our
version.

> > 
> > Index: x11-toolkits/gtk30/Makefile
> > ===================================================================
> > --- x11-toolkits/gtk30/Makefile	(revision 439205)
> > +++ x11-toolkits/gtk30/Makefile	(revision 439206)
> > @@ -4,8 +4,8 @@
> >  # adwaita-icon-theme, gnome-themes-standard and mate-themes
> > 
> >  PORTNAME=	gtk
> > -PORTVERSION=	3.18.8
> > -PORTREVISION?=	4
> > +PORTVERSION=	3.22.12
> 3.20 changed ABI, so you need to bump PORTREVISION in consumers.
> 
> https://abi-laboratory.pro/tracker/timeline/gtk+/

Yes it reports ABI breakage, great site btw. However these removed
symbols are all in de gdk_wayland_* space. I assume wayland got removed
from the test system.. Anyway, since wayland support wasn't enabled
this is not a problem.

https://abi-laboratory.pro/tracker/compat_report/gtk+/3.18.9/3.20.0/a91
f6/abi_compat_report.html

> > 
> > @@ -54,7 +56,7 @@ GLIB_SCHEMAS=	org.gtk.Demo.gschema.xml \
> >  		org.gtk.Se@@ -76,6 +78,8 @@
> > CLOUDPRINT_LIB_DEPENDS=	librest-0.7.so:devel/libreema.xml \
> >  		org.gtk.Settings.FileChooser.gschema.xml
> > 
> > -OPTIONS_DEFINE=	CUPS CLOUD+RINT COLORD DEBUG BROADWAY
> > +OPTIONS_DEFINE=	CUPS CLOUDPRINT COLORD +ROADWAY
> Can you revert this
>  hunk? After that bump PORTREVISION as BROADWAY is
> enabled by default.

Conside it done, I will add a little info too, from your commit so I
don't accidently change it.

Thanks, for your feedback!

-Koop



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1493031346.1415.7.camel>