Date: Sun, 19 Feb 2017 22:00:11 +0000 (UTC) From: Ngie Cooper <ngie@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r313973 - head/tests/sys/geom/eli/pbkdf2 Message-ID: <201702192200.v1JM0B3e013451@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ngie Date: Sun Feb 19 22:00:11 2017 New Revision: 313973 URL: https://svnweb.freebsd.org/changeset/base/313973 Log: A forced commit to note other portion of the Makefile change accidentally committed in r313972 The code committed in r313962 implicitly relies on python 2.x to generate testvect.h . There are a handful of issues with this approach: - python is not an explicit build dependency for FreeBSD - python 2.x is deprecated and will be removed sometime in the future (potentially before 11.x's EOL), and the script does not function with python 3.5 (it uses deprecated idioms and incompatible function calls). - python(1) (by default) lives in /usr/local/bin (${LOCALBASE}/bin) and gentestvect.py is a dependency of testvect.h (prior to r313972) which means that if the mtime of the generator script was newer than the mtime of the test vector, it could cause a spurious build failure in build time or at install time. A better solution using C/C++ should be devised. Discussed with: allanjude MFC after: 2 weeks X-MFC with: r313962, r313972 Sponsored by: Dell EMC Isilon Modified: head/tests/sys/geom/eli/pbkdf2/Makefile Modified: head/tests/sys/geom/eli/pbkdf2/Makefile ============================================================================== --- head/tests/sys/geom/eli/pbkdf2/Makefile Sun Feb 19 21:19:44 2017 (r313972) +++ head/tests/sys/geom/eli/pbkdf2/Makefile Sun Feb 19 22:00:11 2017 (r313973) @@ -23,6 +23,6 @@ SRCS.pbkdf2= \ LIBADD.pbkdf2= crypto testvect.h: - python gentestvect.py > $@ + python gentestvect.py > ${.TARGET} .include <bsd.test.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702192200.v1JM0B3e013451>