Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Sep 2017 08:16:22 +0000 (UTC)
From:      Andrew Turner <andrew@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r323845 - stable/11/sys/arm64/arm64
Message-ID:  <201709210816.v8L8GMcj022584@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: andrew
Date: Thu Sep 21 08:16:21 2017
New Revision: 323845
URL: https://svnweb.freebsd.org/changeset/base/323845

Log:
  MFC r322797:
  
  Fix a bug in pmap_protect where we invalidate the wrong page. With this we
  can now remove an unneeded call to invalidate all entries.
  
  Sponsored by:	DARPA, AFRL

Modified:
  stable/11/sys/arm64/arm64/pmap.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/arm64/arm64/pmap.c
==============================================================================
--- stable/11/sys/arm64/arm64/pmap.c	Thu Sep 21 07:35:22 2017	(r323844)
+++ stable/11/sys/arm64/arm64/pmap.c	Thu Sep 21 08:16:21 2017	(r323845)
@@ -2626,13 +2626,10 @@ pmap_protect(pmap_t pmap, vm_offset_t sva, vm_offset_t
 			pmap_set(l3p, nbits);
 			PTE_SYNC(l3p);
 			/* XXX: Use pmap_invalidate_range */
-			pmap_invalidate_page(pmap, va);
+			pmap_invalidate_page(pmap, sva);
 		}
 	}
 	PMAP_UNLOCK(pmap);
-
-	/* TODO: Only invalidate entries we are touching */
-	pmap_invalidate_all(pmap);
 }
 
 /*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201709210816.v8L8GMcj022584>