Date: Wed, 24 Oct 2007 00:11:04 GMT From: "Christian S.J. Peron" <csjp@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 127983 for review Message-ID: <200710240011.l9O0B4AW032541@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=127983 Change 127983 by csjp@push on 2007/10/24 00:10:51 Move where we audit the PID argument such that we unconditionally audit it. This fixes a problem where the user supplies an invalid process ID which is > 0 which results in the PID argument not being audited. Affected files ... .. //depot/projects/trustedbsd/audit3/sys/kern/kern_sig.c#21 edit Differences ... ==== //depot/projects/trustedbsd/audit3/sys/kern/kern_sig.c#21 (text+ko) ==== @@ -1693,6 +1693,7 @@ int error; AUDIT_ARG(signum, uap->signum); + AUDIT_ARG(pid, uap->pid); if ((u_int)uap->signum > _SIG_MAXSIG) return (EINVAL); @@ -1709,7 +1710,6 @@ PROC_UNLOCK(p); return (error); } - AUDIT_ARG(pid, uap->pid); switch (uap->pid) { case -1: /* broadcast signal */ return (killpg1(td, uap->signum, 0, 1));
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710240011.l9O0B4AW032541>