Date: Sat, 18 Apr 1998 15:27:39 +1000 From: Bruce Evans <bde@zeta.org.au> To: des@FreeBSD.ORG, peter@netplex.com.au Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs... Message-ID: <199804180527.PAA08431@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>"Dag-Erling C. Sm\xf8rgrav" wrote: >> des 1998/04/17 15:37:20 PDT >> >> Modified files: >> sys/dev/dpt dpt_control.c >> sys/gnu/ext2fs COPYRIGHT.INFO ext2_alloc.c ext2_vnops.c >[..] >> sys/ufs/ufs ufs_vnops.c >> Log: >> Seventy-odd "its" / "it's" typos in comments fixed as per kern/6108. > >What the hell??? I don't call this "fixing typos", as far as I can tell, >most of these changes have broken the correct usage. I didn't notice any incorrect ones. >eg: here, we are talking about the device's softc: >+++ dpt_control.c 1998/03/23 10:49:01 >@@ -175,7 +175,7 @@ > > /** > * Given a minor device number, >- * return the pointer to it's softc structure >+ * return the pointer to its softc structure > */ > > static INLINE dpt_softc_t * The change is correct. You get this wrong so often that I am tempted to reply with a spelling flame :-). >eg: here we are talking about the card's EEROM. >+++ if_ed.c 1998/03/23 11:05:46 >@@ -676,7 +676,7 @@ > #endif > DELAY(100); > outb(sc->asic_addr + ED_WD_MSR, inb(sc->asic_addr + ED_WD_MSR) & ~ED_WD_ >MSR_RST); >- /* wait in the case this card is reading it's EEROM */ >+ /* wait in the case this card is reading its EEROM */ > DELAY(5000); > > sc->vendor = ED_VENDOR_WD_SMC; > >And so on... This change is correct too. >Just because a PR is submitted, it doesn't mean it's right. If they were >always right, there would be an automatic patch application process on PR >submission. Most submissions in PRs (and elsehwere) have style and spelling bugs on almost every line, but this one seems to be an exception :-). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199804180527.PAA08431>