Date: Wed, 27 Dec 2017 15:01:43 -0700 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327166 - head/sys/x86/isa Message-ID: <CANCZdfoH1J=njz4p43e2f9ZrBOS63b1LOKPB5tJA6y244DbYRw@mail.gmail.com> In-Reply-To: <d803faa8-e361-4c99-9d57-537503dc4266@FreeBSD.org> References: <201712241759.vBOHxm5d005082@repo.freebsd.org> <d803faa8-e361-4c99-9d57-537503dc4266@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 27, 2017 2:56 PM, "John Baldwin" <jhb@freebsd.org> wrote: On 12/24/17 9:59 AM, Warner Losh wrote: > Author: imp > Date: Sun Dec 24 17:59:48 2017 > New Revision: 327166 > URL: https://svnweb.freebsd.org/changeset/base/327166 > > Log: > Further investigation shows this shouldn't have been added at all. > Remove it. > > Modified: > head/sys/x86/isa/orm.c > > Modified: head/sys/x86/isa/orm.c > ============================================================ ================== > --- head/sys/x86/isa/orm.c Sun Dec 24 16:53:55 2017 (r327165) > +++ head/sys/x86/isa/orm.c Sun Dec 24 17:59:48 2017 (r327166) > @@ -156,7 +156,6 @@ orm_identify(driver_t* driver, device_t parent) > device_set_desc(child, "ISA Option ROM"); > else > device_set_desc(child, "ISA Option ROMs"); > -// isa_set_vendorid(child, PNP_EISAID("PNP0C80")); > } So does this mean orm0 will trigger warnings in GENERIC now? No. The setting was redundant. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoH1J=njz4p43e2f9ZrBOS63b1LOKPB5tJA6y244DbYRw>