Date: Sun, 17 Aug 2014 21:41:11 +0200 From: Antoine Brodin <antoine@FreeBSD.org> To: Kurt Jaeger <pi@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r365227 - head/Mk/Uses Message-ID: <CAALwa8n_GQse%2BQt41Yxeu=%2BLV7J=UZizBsHn5GLoRWVtBi=y6A@mail.gmail.com> In-Reply-To: <20140817193838.GO42528@f10.opsec.eu> References: <201408171932.s7HJWIkV088586@svn.freebsd.org> <CAALwa8mFdvSQRPgPVntA4x%2BQMH2ceVOWQXB1KZiGHQEGA4M9gw@mail.gmail.com> <20140817193838.GO42528@f10.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Aug 17, 2014 at 9:38 PM, Kurt Jaeger <pi@freebsd.org> wrote:
> Hi!
>
>> > Log:
>> > Mk/Uses/perl5.mk: Fix logic for removal of empty .bs files
> [...]
>
>> > # Starting with perl 5.20, the empty bootstrap files are not installed any
>> > # more. As we don't need them anyway, remove it altogether.
>> > -.if ${PERL_LEVEL} < 502000
>> > +.if ${PERL_LEVEL} >= 502000
>> > fix-perl-bs:
>> > -@${FIND} ${STAGEDIR} -name '*.bs' -size 0 -delete
>> > .endif
>>
>>
>> This is totally wrong, please revert.
>
> I had the case with devel/p5-File-Map that it still installs a
> .bs in the STAGEDIR. So I searched on how to fix it and found this
> please in Mk/Uses/perl5.mk and thought:
>
> Isn't the logic the wrong way around ?
>
> Please explain the logic behind the fix-perl-bs for ${PERL_LEVEL} >= 502000 ?
The logic is that with perl 5.20, you don't need to remove the .bs files.
Cheers,
Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8n_GQse%2BQt41Yxeu=%2BLV7J=UZizBsHn5GLoRWVtBi=y6A>