Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 05 Dec 2016 13:49:50 -0800
From:      John Baldwin <jhb@freebsd.org>
To:        Andriy Gapon <avg@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   Re: svn commit: r308371 - in stable/10: share/man/man4 sys/conf sys/dev/jedec_ts sys/modules/i2c sys/modules/i2c/jedec_ts
Message-ID:  <1625245.4edrXav981@ralph.baldwin.cx>
In-Reply-To: <201611061356.uA6DuYcO079294@repo.freebsd.org>
References:  <201611061356.uA6DuYcO079294@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, November 06, 2016 01:56:34 PM Andriy Gapon wrote:
> Author: avg
> Date: Sun Nov  6 13:56:34 2016
> New Revision: 308371
> URL: https://svnweb.freebsd.org/changeset/base/308371
> 
> Log:
>   MFC r307768: jedec_ts: a driver for thermal sensors on memory modules
> 
> Added:
>   stable/10/share/man/man4/jedec_ts.4
>      - copied unchanged from r307768, head/share/man/man4/jedec_ts.4
>   stable/10/sys/dev/jedec_ts/
>      - copied from r307768, head/sys/dev/jedec_ts/
>   stable/10/sys/modules/i2c/jedec_ts/
>      - copied from r307768, head/sys/modules/i2c/jedec_ts/
> Modified:
>   stable/10/sys/conf/NOTES
>   stable/10/sys/conf/files
>   stable/10/sys/modules/i2c/Makefile
> Directory Properties:
>   stable/10/   (props changed)

FYI, this doesn't work and has broken tinderbox builds on stable/10.
smbus_get_addr() doesn't exist on 10.  It was originally a hand-rolled
ivar wrapper that was removed in r93023 in 2002.  The function prototype
was not removed, so the compile works, but linking fails.  The stale
prototype is still present in smbconf.h in HEAD (and should be removed).
The "real" smbus_get_addr() was added back to smbconf.h along with an
implementation of smbus_read_ivar() in r281985.  Parts of that commit
probably need to be MFC'd to 10.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1625245.4edrXav981>