Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Jan 2016 13:37:31 +0100
From:      Oliver Pinter <oliver.pinter@hardenedbsd.org>
To:        Allan Jude <allanjude@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org,  svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   Re: svn commit: r293865 - stable/10/usr.sbin/sesutil
Message-ID:  <CAPQ4ffs6zmBgjWxRkT7T_uUems0gbuUYh7Rp3%2BoGqmhV7NH1sQ@mail.gmail.com>
In-Reply-To: <CAPQ4fftWrEaEf573hd4-B_2pXH_gQF6iP44PmVmq5vF-1Oidxg@mail.gmail.com>
References:  <201601140142.u0E1gAFE089373@repo.freebsd.org> <CAPQ4fftWrEaEf573hd4-B_2pXH_gQF6iP44PmVmq5vF-1Oidxg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 1/14/16, Oliver Pinter <oliver.pinter@hardenedbsd.org> wrote:
> On 1/14/16, Allan Jude <allanjude@freebsd.org> wrote:
>> Author: allanjude
>> Date: Thu Jan 14 01:42:09 2016
>> New Revision: 293865
>> URL: https://svnweb.freebsd.org/changeset/base/293865
>>
>> Log:
>>   MFC: r287473
>>     Add the new sesutil(8) utility for managing SCSI Enclosure Services
>> (SES) device.
>>
>>   MFC: r287493
>>     Fix iteration bug
>>
>>   MFC: r287485, r287494, r287992
>>     Please the angry gcc 4.2 gods
>>
>>   MFC: r287988
>>     Improve and expand sesutil(8)
>>
>>     Return an error if no matching device is found
>>     Locate can address a slot, in addition to a drive
>>     Added fault, similar to locate but blinks a different LED
>>     Added the map command, lists all devices connected to the SES
>> controller
>>     Added the status command, overall status of the SES controller
>>
>>   MFC: r292092
>>     sesutil: fix map not printing the status of the LED device in an
>> array
>>
>>   MFC: r292093
>>     sesutil: pass the correct element type when printing the SES map
>>
>>   MFC: r292121
>>     sesutil: Add extra information specific to some SES devices to
>> sesutil
>> map
>>
>>   MFC: r292122
>>     Fix sesutil locate when a sesid is passed to locate command
>>
>>   MFC: r292262
>>     Show the enclosure name and id in sesutil map
>>
>>   Relnotes:	yes
>>   Sponsored by:	Gandi.net
>>   Sponsored by:	ScaleEngine Inc.
>>
>> Added:
>>   stable/10/usr.sbin/sesutil/eltsub.c
>>      - copied, changed from r287988, head/usr.sbin/sesutil/eltsub.c
>>   stable/10/usr.sbin/sesutil/eltsub.h
>>      - copied, changed from r287988, head/usr.sbin/sesutil/eltsub.h
>> Modified:
>>   stable/10/usr.sbin/sesutil/Makefile
>>   stable/10/usr.sbin/sesutil/sesutil.8
>>   stable/10/usr.sbin/sesutil/sesutil.c
>> Directory Properties:
>>   stable/10/   (props changed)
>>
>> Modified: stable/10/usr.sbin/sesutil/Makefile
>
> This commit breaks the build on 10-STABLE::
>
> --- rescue.all__D ---
> sh_stub.c:1:66: warning: implicit declaration of function 'main' is
> invalid in C99 [-Wimplicit-function-declaration]
> int _crunched_sh_stub(int argc, char **argv, char **envp){return
> main(argc,argv,envp);}
>                                                                  ^
> --- usr.sbin.all__D ---
> --- all_subdir_sesutil ---
> sesutil.o: In function `objmap':
> /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/sesutil.c:(.text+0x561):
> undefined reference to `sbuf_len'
> /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/sesutil.c:(.text+0x56e):
> undefined reference to `sbuf_data'
> /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/sesutil.c:(.text+0x588):
> undefined reference to `sbuf_delete'
> eltsub.o: In function `stat2sbuf':
> /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x4db):
> undefined reference to `sbuf_new'
> /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x4fd):
> undefined reference to `sbuf_printf'
> /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x513):
> undefined reference to `sbuf_printf'
> /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x529):
> undefined reference to `sbuf_printf'
> /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x587):
> undefined reference to `sbuf_printf'
> /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x5a5):
> undefined reference to `sbuf_printf'
> eltsub.o:/jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x5bc):
> more undefined references to `sbuf_printf' follow
> eltsub.o: In function `stat2sbuf':
> /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x5e6):
> undefined reference to `sbuf_finish'
> --- secure.all__D ---
>
> More info about the error:
> http://jenkins.hardenedbsd.org:8180/jenkins/job/HardenedBSD-10-STABLE-amd64/lastFailedBuild/console

Ahh, sorry, I missed your r293876 commit, which would fix the issue.

[...]



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4ffs6zmBgjWxRkT7T_uUems0gbuUYh7Rp3%2BoGqmhV7NH1sQ>