Date: Wed, 19 Nov 2008 01:18:20 +0200 From: Alexander Motin <mav@FreeBSD.org> To: Maxim Konovalov <maxim@macomnet.ru> Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG Subject: Re: svn commit: r185053 - head/usr.sbin/powerd Message-ID: <49234D3C.5030605@FreeBSD.org> In-Reply-To: <20081118234224.M56769@mp2.macomnet.net> References: <200811181548.mAIFmNuL081972@svn.freebsd.org> <20081118234224.M56769@mp2.macomnet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Konovalov wrote: >> Author: mav >> Date: Tue Nov 18 15:48:23 2008 >> New Revision: 185053 >> URL: http://svn.freebsd.org/changeset/base/185053 >> >> Log: >> Restore original frequency on exit. >> >> PR: bin/113813 >> > [ patch skipped ] > > Not sure this is a correct aproach. What happen if admin > changed (rose or lowered) the debug.cpufreq.lowest after he > run powerd? So imho at exit we need to take an account a > current value of debug.cpufreq.lowest. Then powerd may not restore original frequency. IMHO it is a bad idea to modify anything frequency related while powerd is running as it reads frequency set only once and them mostly writes. Every tool should have it's own task. powerd has no idea about debug.cpufreq.lowest, especially because of "debug.". It is kernel internal business, how to generate set of frequencies. If we need specify lowest frequency for adaptive mode, I would teach powerd to do it, not the kernel. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49234D3C.5030605>