Date: Wed, 31 May 2017 11:48:29 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Emmanuel Vadot <manu@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r319125 - head/usr.bin/mkimg Message-ID: <20170531114829.28359de76187bdd184746b5a@bidouilliste.com> In-Reply-To: <FAFD6561-D529-4750-A72F-26767E65F6A5@gmail.com> References: <201705291251.v4TCp24h090283@repo.freebsd.org> <FAFD6561-D529-4750-A72F-26767E65F6A5@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 31 May 2017 00:20:45 -0700 "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> wrote: > > > On May 29, 2017, at 05:51, Emmanuel Vadot <manu@FreeBSD.org> wrote: > > > > Author: manu > > Date: Mon May 29 12:51:02 2017 > > New Revision: 319125 > > URL: https://svnweb.freebsd.org/changeset/base/319125 > > > > Log: > > mkimg: Correct an off by one error in the PMBR size > > > > The PMBR last sector should be number of sector - 1 (As stated in UEFI Spec > > 2.6 page 118 table 17). > > This fixes warning printed by linux tools like parted or fdisk. > > This commit broke all of the mkimg gpt tests. For example: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/3280/testReport/junit/usr.bin.mkimg/mkimg_test/gpt_1x1_4096_qcow/ . > -Ngie Sorry about that and thanks for the fix. -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170531114829.28359de76187bdd184746b5a>