Date: Tue, 11 Jan 2000 22:42:55 -0500 (EST) From: ajk@waterspout.com To: FreeBSD-gnats-submit@freebsd.org Subject: ports/16077: [PATCH] GNOME diskusage applet inconsistent with df program Message-ID: <200001120342.WAA02629@tempest.waterspout.com>
next in thread | raw e-mail | index | archive | help
>Number: 16077 >Category: ports >Synopsis: [PATCH] GNOME diskusage applet inconsistent with df program >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jan 11 19:50:02 PST 2000 >Closed-Date: >Last-Modified: >Originator: Andrew J. Korty >Release: FreeBSD 4.0-CURRENT i386 >Organization: Waterspout Communications, Inc. >Environment: FreeBSD tempest.waterspout.com 4.0-CURRENT FreeBSD 4.0-CURRENT #24: Sat Dec 4 08:11:45 EST 1999 root@tempest.waterspout.com:/usr/src/sys/compile/TEMPEST i386 >Description: The GNOME diskuage applet shows the amount of space available to mortal users on a given filesystem in kilobytes and the percentage available as a pie graph. While the calculation of the available space correctly subtracts the space unavailable to mortals (as does the df program), this space is not subtracted from the calculated total size of the filesystem. Therefore, the pie graph depicts too large a portion of the filesystem as available. >How-To-Repeat: Type "diskuage" while running the GNOME panel. >Fix: --- applets/diskusage/diskusage_read.c.orig Wed Jan 5 16:07:20 2000 +++ applets/diskusage/diskusage_read.c Wed Jan 5 16:11:23 2000 @@ -76,12 +76,14 @@ ps->filesystems[i].sizeinfo [DU_FS_TOTAL] = fsu.blocks; #ifdef ADD_RESERVED_SPACE ps->filesystems[i].sizeinfo [DU_FS_FREE] = fsu.bfree; #else + ps->filesystems[i].sizeinfo [DU_FS_TOTAL] -= + fsu.bfree - fsu.bavail; ps->filesystems[i].sizeinfo [DU_FS_FREE] = fsu.bavail; #endif ps->filesystems[i].sizeinfo [DU_FS_USED] = fsu.blocks - fsu.bfree; >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001120342.WAA02629>