Date: Fri, 16 Aug 2002 05:23:20 -0700 From: Terry Lambert <tlambert2@mindspring.com> To: Maxim Sobolev <max@vega.com> Cc: Iasen Kostov <ikostov@otel.net>, Julian Elischer <julian@elischer.org>, Maxim Sobolev <sobomax@FreeBSD.ORG>, hackers@FreeBSD.ORG, net@FreeBSD.ORG Subject: Re: Increasing size of if_flags field in the ifnet structure [patch Message-ID: <3D5CEEB8.EFDBF659@mindspring.com> References: <200208161222.g7GCM8Rt005388@vega.vega.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Sobolev wrote: > > > There is no much point in this patch, because it will increase size of > > > struct ifreq, which means that no ioctl's from older apps will be accepted > > > anyway. Therefore, there is no difference between those two, while my > > > approach is obviously cleaner. > > > > It does not increase size of struct ifreq. > > This is a union not a struct as You see. > > Oh, yes, you are obviously correct. However, I still wonder if your patch > is endianless-safe. It's not, unless the structure packing is "just so". First thing I notices, and exactly what Bruce was pointing out when he referred to "other architectures", I think. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D5CEEB8.EFDBF659>