Date: Tue, 26 Jan 2021 23:34:17 +0000 From: Brooks Davis <brooks@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Brooks Davis <brooks@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d89c1c461ce3 - main - Reserve gaps in syscall numbers for local use Message-ID: <20210126233417.GA6607@spindle.one-eyed-alien.net> In-Reply-To: <YBCcu0oFxzFSl4Fd@kib.kiev.ua> References: <202101261828.10QISOKh066392@gitrepo.freebsd.org> <YBCcu0oFxzFSl4Fd@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--FCuugMFkClbJLl1L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 27, 2021 at 12:50:35AM +0200, Konstantin Belousov wrote: > On Tue, Jan 26, 2021 at 06:28:24PM +0000, Brooks Davis wrote: > > The branch main has been updated by brooks: > >=20 > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd89c1c461ce31bfc789dbb7b= c5f4fce5824c595e > >=20 > > commit d89c1c461ce31bfc789dbb7bc5f4fce5824c595e > > Author: Brooks Davis <brooks@FreeBSD.org> > > AuthorDate: 2021-01-26 18:27:45 +0000 > > Commit: Brooks Davis <brooks@FreeBSD.org> > > CommitDate: 2021-01-26 18:27:45 +0000 > >=20 > > Reserve gaps in syscall numbers for local use > > =20 > > It is best for auditing of syscalls.master if we only append to the > > file. Reserving unimplemented system call numbers for local use ma= kes > > this policy and provides a large set of syscall numbers FreeBSD > > derivatives can use without risk of conflict. > > =20 > > Reviewed by: jhb, kevans, kib > > Sponsored by: DARPA > > Differential Revision: https://reviews.freebsd.org/D27988 > > --- > > sys/kern/init_sysent.c | 120 +++++++++++++++++++++++----------------= -------- > > sys/kern/syscalls.c | 120 +++++++++++++++++++++++----------------= -------- > > sys/kern/syscalls.master | 55 ++++++++++------------ > > 3 files changed, 145 insertions(+), 150 deletions(-) > I highly dislike this. You committed both manually edited file and gener= ated > files in one commit. Can we please avoid this? >=20 > It is hard/impossible to read the diff as is. While in this case it would be harmless to split the changes, I strongly disagree with the concept of separating syscalls.master changes and generated files because in the common case (adding syscalls) it requires that the first commit break the build. -- Brooks --FCuugMFkClbJLl1L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJgEKb4AAoJEKzQXbSebgfAXKsH/Rnfkc1i61z7J3usGY9zBfGn n9jLvwwsm8p2o7p/jv+UF5/o9uLs3a6mXwjzwUFZPAzP+uF81+7dAFf/FxI2K97G DrIXq7kM2Ia4OtoUKedAiaga1y/XozenPKhzbKPsuPZ7VNJB8DJu7p8a8KYKHp0U HgbdL8Llo+HbvevxiSbAl3oILWkNKOQf8SWiP0ZHHkvDA37VcBwtknGgtpU405pI un0bMeK1oCJcarJOd9NX0RF2tzVP6TR+iHdAgG92fAw9xdqqxu+58xjODhYTy5xU 4IMrEIOloA8P+AiAhkBSFxfOw73xRAdn0Di0sfKR3xkJeDUc29TDpSwRWYXeQQ8= =GUWG -----END PGP SIGNATURE----- --FCuugMFkClbJLl1L--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210126233417.GA6607>