Date: Thu, 30 Sep 2010 06:06:49 -0700 From: Jeremy Chadwick <freebsd@jdc.parodius.com> To: Paul Mather <paul@gromit.dlib.vt.edu> Cc: Ed Schouten <ed@80386.nl>, freebsd-stable@FreeBSD.org, Alex Dupre <ale@FreeBSD.org> Subject: Re: mysqld_safe holding open a pty/tty on FreeBSD (7.x and 8.x) Message-ID: <20100930130649.GA18206@icarus.home.lan> In-Reply-To: <E04F963B-7AAF-4483-8B60-6BBA2AFCCD28@gromit.dlib.vt.edu> References: <20100930065151.GA9634@icarus.home.lan> <20100930070333.GU87427@hoeg.nl> <20100930072819.GA10678@icarus.home.lan> <4CA43C91.5040000@FreeBSD.org> <20100930075616.GA11519@icarus.home.lan> <E04F963B-7AAF-4483-8B60-6BBA2AFCCD28@gromit.dlib.vt.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 30, 2010 at 08:53:07AM -0400, Paul Mather wrote:
> On Sep 30, 2010, at 3:56 AM, Jeremy Chadwick wrote:
>
> > The diff is pretty obvious/simple (2 line change), so the other
> > databases/mysqlXX-server ports can be upgraded in the same manner.
> >
> > --- files/mysql-server.sh.in.orig 2010-03-27 03:24:53.000000000 -0700
> > +++ files/mysql-server.sh.in 2010-09-30 00:45:38.000000000 -0700
> > @@ -35,8 +35,8 @@
> > mysql_user="mysql"
> > mysql_limits_args="-e -U ${mysql_user}"
> > pidfile="${mysql_dbdir}/`/bin/hostname`.pid"
> > -command="%%PREFIX%%/bin/mysqld_safe"
> > -command_args="--defaults-extra-file=${mysql_dbdir}/my.cnf --user=${mysql_user} --datadir=${mysql_dbdir} --pid-file=${pidfile} ${mysql_args} > /dev/null 2>&1 &"
> > +command="/usr/sbin/daemon"
> > +command_args="-c -f /usr/local/bin/mysqld_safe --defaults-extra-file=${mysql_dbdir}/my.cnf --user=${mysql_user} --datadir=${mysql_dbdir} --pid-file=${pidfile} ${mysql_args}"
>
> Shouldn't this be "-c -f %%PREFIX%%/bin/mysqld_safe ..." rather than hard-coding /usr/local?
Yes.
--
| Jeremy Chadwick jdc@parodius.com |
| Parodius Networking http://www.parodius.com/ |
| UNIX Systems Administrator Mountain View, CA, USA |
| Making life hard for others since 1977. PGP: 4BD6C0CB |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100930130649.GA18206>