Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Sep 2018 19:55:40 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r338509 - head/sys/netinet
Message-ID:  <201809061955.w86JteY6084001@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bz
Date: Thu Sep  6 19:55:40 2018
New Revision: 338509
URL: https://svnweb.freebsd.org/changeset/base/338509

Log:
  The inp_lle field to struct inpcb, along with two "valid" flags
  for the rt and lle cache were added in r191129 (2009).
  To my best knowledge they have never been used and route caching
  has converted the inp_rt field from that commit to inp_route
  rendering this field and these flags obsolete.
  
  Convert the pointer into a spare pointer to not change the size of
  the structure anymore (and to have a spare pointer) and mark the
  two fields as unused.
  
  Reviewed by:	markj, karels
  Approved by:	re (gjb)
  Differential Revision:	https://reviews.freebsd.org/D17062

Modified:
  head/sys/netinet/in_pcb.h

Modified: head/sys/netinet/in_pcb.h
==============================================================================
--- head/sys/netinet/in_pcb.h	Thu Sep  6 19:42:40 2018	(r338508)
+++ head/sys/netinet/in_pcb.h	Thu Sep  6 19:55:40 2018	(r338509)
@@ -320,7 +320,7 @@ struct inpcb {
 	CK_LIST_ENTRY(inpcb) inp_portlist;	/* (i/h) */
 	struct	inpcbport *inp_phd;	/* (i/h) head of this list */
 	inp_gen_t	inp_gencnt;	/* (c) generation count */
-	struct llentry	*inp_lle;	/* cached L2 information */
+	void		*spare_ptr;	/* Spare pointer. */
 	rt_gen_t	inp_rt_cookie;	/* generation for route entry */
 	union {				/* cached L3 information */
 		struct route inp_route;
@@ -744,8 +744,8 @@ int	inp_so_options(const struct inpcb *inp);
 /*
  * Flags for inp_flags2.
  */
-#define	INP_LLE_VALID		0x00000001 /* cached lle is valid */	
-#define	INP_RT_VALID		0x00000002 /* cached rtentry is valid */
+#define	INP_2UNUSED1		0x00000001
+#define	INP_2UNUSED2		0x00000002
 #define	INP_PCBGROUPWILD	0x00000004 /* in pcbgroup wildcard list */
 #define	INP_REUSEPORT		0x00000008 /* SO_REUSEPORT option is set */
 #define	INP_FREED		0x00000010 /* inp itself is not valid */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809061955.w86JteY6084001>