Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 May 2021 19:32:02 +0100
From:      Jessica Clarke <jrtc27@freebsd.org>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: 086feed850c3 - main - md5: Create md5sum, etc compatible programs
Message-ID:  <9BE6FB36-5958-4220-9C95-86DED767F6ED@freebsd.org>
In-Reply-To: <202105191744.14JHi6fA008046@gitrepo.freebsd.org>
References:  <202105191744.14JHi6fA008046@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 19 May 2021, at 18:44, Warner Losh <imp@FreeBSD.org> wrote:
>=20
> The branch main has been updated by imp:
>=20
> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3D086feed850c31c278f25c958b97992d0=
24139896
>=20
> commit 086feed850c31c278f25c958b97992d024139896
> Author:     Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2021-05-19 17:26:20 +0000
> Commit:     Warner Losh <imp@FreeBSD.org>
> CommitDate: 2021-05-19 17:41:53 +0000
>=20
>    md5: Create md5sum, etc compatible programs
>=20
>    On Linux, there's a similar set of programs to ours, but that end =
in the
>    letters 'sum'. These act basically like FreeBSD versions run with =
the -r
>    option. Add code so that when the program ends in 'sum' you get the
>    linux -r behavior. This is enough to make most things that use =
sha*sum
>    work correctly (the -c / --check options, as well as the long args =
are
>    not implemented). When running with the -sum programs, ignore -t =
instead
>    of running internal speed tests and make -c an error.
>=20
>    Reviewed by:            sef, and kp and allanjude (earlier version)
>    Relnotes:               yes
>    Sponsored by:           Netflix
>    Differential Revision:  https://reviews.freebsd.org/D30309
> ---
> diff --git a/sbin/md5/md5.c b/sbin/md5/md5.c
> index 96dfcede9711..4381ef124c7b 100644
> --- a/sbin/md5/md5.c
> +++ b/sbin/md5/md5.c
> @@ -177,13 +177,32 @@ main(int argc, char *argv[])
> 	char	buf[HEX_DIGEST_LENGTH];
> 	size_t	len;
>  	unsigned	digest;
> - 	const char*	progname;
> +	char	*progname;
> +	bool	gnu_emu =3D false;

This file doesn=E2=80=99t currently include stdbool.h explicitly, and =
apparently that
is not implicitly included by any of the headers on Linux (and I cannot =
work
out where it comes from on FreeBSD). Could you please add the explicit =
include
to fix cross-building?

Thanks,
Jess




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9BE6FB36-5958-4220-9C95-86DED767F6ED>