Date: Fri, 4 Oct 2013 19:19:47 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Scott Long <scott4long@yahoo.com> Cc: "FreeBSD-scsi@freebsd.org" <FreeBSD-scsi@freebsd.org> Subject: Re: pci_alloc_msi is always called, is this bad? Message-ID: <20131004161947.GU41229@kib.kiev.ua> In-Reply-To: <94C7BB39-A287-44D4-9992-E8DAE83CE6D4@yahoo.com> References: <CAFMmRNzWwxe=YVJcC7Lkjqru5eugciwzEQHjgE-Bh-ctOykVNQ@mail.gmail.com> <20131003194704.GG41229@kib.kiev.ua> <1380902209.2621.11.camel@localhost> <94C7BB39-A287-44D4-9992-E8DAE83CE6D4@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--ImgWj/n5mMvZ1QVT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Oct 04, 2013 at 10:05:18AM -0600, Scott Long wrote:
> It used to be that gcc would generate code that would conditionally execu=
te the second clause only if the first clause were true. If that's not lon=
ger the case (with gcc and/or clang), then I bet that UDF will break due to=
this:
>=20
> /*
> * Check to see if the fid is fragmented. The first test
> * ensures that we don't wander off the end of the buffer
> * looking for the l_iu and l_fi fields.
> */
> if (ds->off + UDF_FID_SIZE > ds->size ||
> ds->off + le16toh(fid->l_iu) + fid->l_fi + UDF_FID_SIZE > ds-=
>size){
Is this some sort of joke ?
C 'and' and 'or' logical operators are short-circuit. It is not
compiler-depended.
--ImgWj/n5mMvZ1QVT
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (FreeBSD)
iQIcBAEBAgAGBQJSTuqiAAoJEJDCuSvBvK1BpmcP/2jhDRiUqchmjr/iWpJ1Nsbb
lIZuwTm+jzd+YV3rmgOHm+HJBX9HkN2jhuRw8lEV0LLw4dpJ39LxbDLcPx+2SX1u
lFBzVsIZOObf0d50yqNRofC0sHGrbki2+xV3mEoS1XkLP7W2LN/MdNLpsHo35fOl
zQYwfBbeglfT8Lc/ZPbxE/4ViL8RUBL62+dBBw6gwVrkWrNylzO7e5gv0x/CTFcA
eT0mtBsswEx4qAo8/hR244vxxAm8eQLjdntGRHPYQj6kwnQwxBg+9NE5IMoA6esT
8fleCrgJIhuBeA/ul1Hz2pDeEj3M7f2cvww3GAKMIQMPppizGRanzYNvMqsL6T08
ZM0RSN7PWPsWIeQktXPO17XvuHkBizIfOESP3ahQVbfZQvRcfsy1+yK4hpawm2/w
LPuNEXUrkljeJ34oBPYAzJhQMfNqq1AMsTknpg4TiNMjJtc7jHi3wLcl3FNAMcX/
VlTUk3DumA8yCQ5LOhcldfNaIaOofMK8+JZ8ppxalfis5st32bjeHb0EJzHa5Ndb
wZX9ZMJN1ac699DmAXasf7sgTOy2vCUwLGrU6wpG3vNFrshu7c5PKUHnh6ChejnV
svSQnVdj1WQnFV4WooH+HFXWydzz+MHJ6YEGsk48IuiHN5TbZpYQ1jE8617Rfjpr
atuReiBcAgEXQ6EYCDgw
=ZiWM
-----END PGP SIGNATURE-----
--ImgWj/n5mMvZ1QVT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131004161947.GU41229>