Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Jan 2004 20:03:58 -0500
From:      Joe Marcus Clarke <marcus@marcuscom.com>
To:        Kris Kennaway <kris@obsecurity.org>
Cc:        ports@freebsd.org
Subject:   Re: Recursive make speedup patch
Message-ID:  <1075079038.93327.27.camel@shumai.marcuscom.com>
In-Reply-To: <20040126000817.GA33860@xor.obsecurity.org>
References:  <20040126000817.GA33860@xor.obsecurity.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--=-A5QPClbkajiLkyhFIMoc
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sun, 2004-01-25 at 19:08, Kris Kennaway wrote:
> The patch available at
>=20
>   http://people.freebsd.org/~kris/recursive-speedup.patch
>=20
> gives a 43% speedup for 'make index' in my testing:
>=20
> No optimization
> 1899.40 real       648.67 user      1148.96 sys
>=20
> Optimized version
> 1096.76 real       504.48 user       565.90 sys

Wow, nice job.

>=20
> The optimizations I used were:
>=20
> * Don't unconditionally include <bsd.gnome.mk> twice for every port;
> only do so if the port defines USE_GNOME or WANT_GNOME.  I had to
> modify a couple of ports to make this work, and I'm not 100% certain
> there are no unintended side-effects.

I've briefly looked through some of the modifications to the ports, and
they look okay.  Looks like some of these ports were misbehaved when it
came to USE_GNOME anyway.

>=20
> * 'make index' and 'make describe' use some perl code, which might be
> optimized or rewritten (e.g. replaced by an awk script, which would
> have the further benefit of working out of the box on 5.x).

I was planning on redoing some of the Perl per my email to you on that
old PR.  However, I can look at an awk rewrite as well.

>=20
> I have not yet tried a port build with these patches - I'd be most
> concerned about the bsd.gnome.mk inclusion change.  Please let me know
> if you run into any problems.

I'll take a closer look, and I'll be sure to include this in the next
4-exp build.

Joe

>=20
> Kris
>=20
--=20
PGP Key : http://www.marcuscom.com/pgp.asc

--=-A5QPClbkajiLkyhFIMoc
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQBAFGd+b2iPiv4Uz4cRAq2fAJ0XwOwueta2xZqpihlj3eD1eNwhOACdF+2c
iU9amUZDe1lqWlHpR6tabYY=
=IQnU
-----END PGP SIGNATURE-----

--=-A5QPClbkajiLkyhFIMoc--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1075079038.93327.27.camel>