Date: Fri, 11 Apr 2008 12:14:52 -0400 From: Coleman Kane <cokane@FreeBSD.org> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: gnome@freebsd.org Subject: Re: Seahorse issues Message-ID: <1207930492.48615.2.camel@localhost> In-Reply-To: <1207929297.55415.13.camel@shumai.marcuscom.com> References: <47FD09AC.2020907@FreeBSD.org> <1207776230.61729.28.camel@shumai.marcuscom.com> <47FD34E8.2000005@FreeBSD.org> <1207872846.87478.38.camel@shumai.marcuscom.com> <47FF66E3.8000304@FreeBSD.org> <47FF722B.109@FreeBSD.org> <1207929297.55415.13.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-aUXdCBOj1sv5DavZCDYE Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2008-04-11 at 11:54 -0400, Joe Marcus Clarke wrote: > On Fri, 2008-04-11 at 10:14 -0400, Coleman Kane wrote: > > I removed your earleir patch, which has the side effect of causing=20 > > gnome_keyring_memory_try_alloc(size) to act in a manner that violates=20 > > its documentation, as well as causing the above bug. I then added the=20 > > three patches to security/seahorse which I posted into=20 > > http://bugzilla.gnome.org/show_bug.cgi?id=3D527193 today: > > * http://bugzilla.gnome.org/attachment.cgi?id=3D109055 > > * http://bugzilla.gnome.org/attachment.cgi?id=3D109056 > > * http://bugzilla.gnome.org/attachment.cgi?id=3D109057 > >=20 > > These three alter the behavior of Seahorse in the manner I described=20 > > above, and don't touch gnome-keyring. For all purposes, I *think*=20 > > gnome-keyring is acting properly here. The consumer of gnome-keyring=20 >=20 > You're right. I was hoping to hack g-k in such a way to avoid having to > fix other broken consumers in the future. Of course, my approach was > very wrong. Thanks for all the help on this. I've now got evolution working with GPG pretty well. >=20 > > (seahorse) should first be testing if the features that it wants to use= =20 > > are actually provided by the library before it blindingly attempts to=20 > > use them. This is, IMHO, why gnome-keyring provides the *_try(...)=20 > > versions of its securemem alloc functions. >=20 > Fixing seahorse is the right thing to do. The bug has been moved into > gnome-keyring's court, so you way want to get them to move it back. >=20 I made the change to the bug already. > >=20 > > Additionally, you'll get a seahorse g_warning about unavailable secure=20 > > memory now too. >=20 > Thanks for your work here. Feel free to commit these patches to our > seahorse port. >=20 > Joe >=20 Thanks, I'll do that later this evening when I have some time after work. -- Coleman Kane --=-aUXdCBOj1sv5DavZCDYE Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEABECAAYFAkf/jnoACgkQcMSxQcXat5fl5ACdEnZDi+kfBB1wR60kqffIGMqg 7OwAni7z5lEkzufkbulqev6Es83qFWhG =0x7P -----END PGP SIGNATURE----- --=-aUXdCBOj1sv5DavZCDYE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1207930492.48615.2.camel>