Date: Wed, 13 Dec 2000 06:11:05 +0900 From: "Akinori MUSHA" <knu@iDaemons.org> To: Peter Pentchev <roam@orbitel.bg> Cc: mharo@FreeBSD.org, ports@FreeBSD.org Subject: Re: portlint - minor patches Message-ID: <867l55wdjq.wl@archon.local.idaemons.org> In-Reply-To: <868zplwe1b.wl@archon.local.idaemons.org> References: <20001212174943.C36405@ringworld.oblivion.bg> <868zplwe1b.wl@archon.local.idaemons.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At Wed, 13 Dec 2000 06:00:32 +0900,
I wrote:
> > Then, there's the other thing - when checking for contiguous blank
> > lines, portlint makes an additional effort to not check patchfiles -
> > it is legitimate for a patch to end with one or more blank lines of
> > context. However, the check is slightly broken - it assumes that
> > filenames are taken relative to the port's directory, while now filenames
> > are absolute. Thus, the /^files\/patch-/ match fails, and patchfiles
> > are also checked for blank lines at the end.
>
> I drastically changed that part to check more effectively and strictly
Bah, it's not the part you mentioned, but the part after that.. I
must need some sleep. ;) Anyway, I fixed it in the better way.
Thanks for catching it, and for indirectly inciting me to improve the
part nearby. :>
--
/
/__ __ Akinori.org / MUSHA.org
/ ) ) ) ) / FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp
"We're only at home when we're on the run, on the wing, on the fly"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?867l55wdjq.wl>