Date: Fri, 3 May 2002 11:46:25 -0700 From: Jonathan Mini <mini@freebsd.org> To: Julian Elischer <julian@elischer.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 10740 for review Message-ID: <20020503114625.E81190@stylus.haikugeek.com> In-Reply-To: <Pine.BSF.4.21.0205030933430.82741-100000@InterJet.elischer.org>; from julian@elischer.org on Fri, May 03, 2002 at 09:38:17AM -0700 References: <20020503085009.C81190@stylus.haikugeek.com> <Pine.BSF.4.21.0205030933430.82741-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer [julian@elischer.org] wrote : > I have no problem with calling it thread_alloc except that your reason was > spurious. (the clash with "itself"). Oh, totally. That commit deserves a little dunce cap. ;) > > > > - uma_zalloc(,M_WAITOK) will never return NULL, so don't bother > > > > testing for it. > > > > > > You may be right, but I wasn't convinced that M_WAITOK was always > > > correct. I was trying to concieve af a case where you may not ba able to > > > wait when trying ot allocate a new thread.. > > > for example if you are trying to allocate it when you are already in > > > msleep().. it may be bad to sleep when in msleep already... > > > I think I may have other ways to stop this but think about it and > > > check the anti-recursion code in msleep(). > > > It may be that M_NOWAIT is the right answer.. > > > > Hmm. Why would you allocate a thread from within msleep()? > > > Umm MOST threads are allocated from either msleep or fork. > > remember in a threaded process you allocate and activate a new thread > when the old one blocks (i.e. is in msleep()). > So to answer your question.. > this is about the most common case.. :-) Oh. I was under the mistaken impression that threads were only created in fork(). -- Jonathan Mini <mini@freebsd.org> http://www.haikugeek.com "He who is not aware of his ignorance will be only misled by his knowledge." -- Richard Whatley To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020503114625.E81190>