Date: Thu, 21 Jul 2011 00:25:45 +0200 From: VANHULLEBUS Yvan <yvan.vanhullebus@netasq.com> To: John Hein <jhein@symmetricom.com> Cc: Doug Barton <dougb@FreeBSD.org>, vanhu@netasq.com, Stephen Montgomery-Smith <stephen@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, maho@FreeBSD.org, cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/security/ipsec-tools Makefile ports/security/ipsec-tools/files racoon.sh.in Message-ID: <20110720222545.GB24725@coruscant> In-Reply-To: <20005.42751.457047.15851@gossamer.timing.com> References: <201107190333.p6J3XQVD050847@repoman.freebsd.org> <4E2542BA.5040203@FreeBSD.org> <20005.42751.457047.15851@gossamer.timing.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--JP+T4n/bALQSJXh8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi all. I'll be mostly AFK until the end of the month, and won't have time/computers to look at / test the patch. Feel free to ask again if you don't have answers during beggining of august. Yvan. On Tue, Jul 19, 2011 at 09:47:11AM -0600, John Hein wrote: > Doug Barton wrote at 01:39 -0700 on Jul 19, 2011: > > This change is an improvement, but it doesn't go far enough in a couple > > of directions. The 2 most important being that faststart is not the on= ly > > possible prefix there, and we don't want that block to run > > unconditionally in any case. > >=20 > > I've attached the full script I'm suggesting because the diff doesn't > > make much sense. One thing I didn't change because I'm not sure if it > > needs to be run early is changing the current require/before to just > > REQUIRE: LOGIN, which is what we prefer ports scripts to do. However if > > there is a good reason for this one to run earlier, that's fine. > >=20 > > If you have any questions, let me know. >=20 > Yes, looks good to me. Well, except the spelling issues: >=20 > sed -E 's,(raccon|raccoon),racoon,g' >=20 >=20 > I'm not sure if there are some lurking subtleties regarding the > require/before question. I'll let Yvan answer that. Commit > history doesn't say anything - it's been REQUIRE: DAEMON & > BEFORE: LOGIN since the beginning - probably just copy/pasted. --JP+T4n/bALQSJXh8 Content-Type: application/x-pkcs7-signature Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIINRQYJKoZIhvcNAQcCoIINNjCCDTICAQExCzAJBgUrDgMCGgUAMAsGCSqGSIb3DQEHAaCC CpEwggaHMIIFb6ADAgECAgpwxrFIFmvykGr5MA0GCSqGSIb3DQEBBAUAMIGRMQswCQYDVQQG EwJGUjENMAsGA1UECBMETm9yZDEaMBgGA1UEBxMRVmlsbGVuZXV2ZSBkJ0FzY3ExLjAsBgNV BAoTJU5FVEFTUSAtIFNlY3VyZSBJbnRlcm5ldCBDb25uZWN0aXZpdHkxJzAlBgNVBAsTHk5F VEFTUSBDZXJ0aWZpY2F0aW9uIEF1dGhvcml0eTAeFw0wOTA3MTUxNDM1NTJaFw0xMTA3MTUx NDM1NTJaMIHYMQswCQYDVQQGFAJGUjENMAsGA1UECBQETm9yZDEuMCwGA1UEChQlTkVUQVNR IC0gU2VjdXJlIEludGVybmV0IENvbm5lY3Rpdml0eTEnMCUGA1UECxQeTkVUQVNRIENlcnRp ZmljYXRpb24gQXV0aG9yaXR5MRowGAYDVQQHFBFWaWxsZW5ldXZlIGQnQXNjcTEZMBcGA1UE AxQQWXZhbiBWQU5IVUxMRUJVUzEqMCgGCSqGSIb3DQEJARYbeXZhbi52YW5odWxsZWJ1c0Bu ZXRhc3EuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA3jBT9ZotVm34ZZ04 Xt9U0CnNbbzvK9iQqYWsFicK0PTdBBow4JcL8YC6n6JQPbKyCBZLT1qAkttvcr0XOQ7xTpYz aW99lV86+YXdfI7NDhvhH6YHwQwnEE/g+xcwbaVlXx47csHmw8icdq+8g6dVjxE24zGjFABg LzVvu9XLZWGehX0Ma5wI+6uTxfLbUTBuVv39nc9u7CWRNKTPXAJ22mBVlEBZIV1T4mQXW1mj ETasTZTxBbmptpoKu4/0GQ8jTSENly4DDAPrCh4bU37atGOQ35lhh6RfFOGoOPfXPVeALkw8 dXDa1+OlDdbv15kn5pO/GtELvSQn9EqOc9BKZQIDAQABo4ICljCCApIwDAYDVR0TAQH/BAIw ADAdBgNVHQ4EFgQUfeVL/YdcaRF4LdilY5dx71Rnumgwgb4GA1UdIwSBtjCBs4AUJyrrHdlE 2joXc2oJICDJJaj5f7KhgZekgZQwgZExCzAJBgNVBAYTAkZSMQ0wCwYDVQQIEwROb3JkMRow GAYDVQQHExFWaWxsZW5ldXZlIGQnQXNjcTEuMCwGA1UEChMlTkVUQVNRIC0gU2VjdXJlIElu dGVybmV0IENvbm5lY3Rpdml0eTEnMCUGA1UECxMeTkVUQVNRIENlcnRpZmljYXRpb24gQXV0 aG9yaXR5ggEAMA4GA1UdDwEB/wQEAwIF4DARBglghkgBhvhCAQEEBAMCBaAwKwYJKwYBBAGC NxQCBB4eHABTAG0AYQByAHQAYwBhAHIAZABMAG8AZwBvAG4wKQYDVR0lBCIwIAYIKwYBBQUH AwQGCCsGAQUFBwMCBgorBgEEAYI3FAICMDYGA1UdEQQvMC2gKwYKKwYBBAGCNxQCA6AdDBt5 dmFuLnZhbmh1bGxlYnVzQG5ldGFzcS5jb20wgc0GA1UdHwSBxTCBwjBaoFigVoZUbGRhcDov L3BraS5uZXRhc3EuY29tL2NuPWZ3Y2Esb3U9Y2FzLG89bmV0YXNxLGRjPWZyP2NlcnRpZmlj YXRlUmV2b2NhdGlvbkxpc3Q7YmluYXJ5MDigNqA0hjJodHRwOi8vaW50cmFuZXQubmV0YXNx LmNvbS9pbnRyYW5ldC9wa2kvbmV0YXNxLmNybDAqoCigJoYkaHR0cDovL3d3dy5uZXRhc3Eu Y29tL3BraS9uZXRhc3EuY3JsMB8GCWCGSAGG+EIBDQQSFhBVc2VyIENlcnRpZmljYXRlMA0G CSqGSIb3DQEBBAUAA4IBAQAMMWGsNbIq1wp+1N8PvDayXhTLyq9NX+R1YWUhz9CO3UOYnfIS rQVanCRzOln4OOTWGHDzx3vaxCmrxym/th9W6Hqxf2jCAoK25HBt6NF7IyFCaESHTEWRu3Zi RR/eBXoPxmYfbWvy7J9VkNkAScHVa8k5VKjf6uratKDnic8+eW0kLMjFlB0kyz1S5jqmMvh/ n3Rq3fgSzLoCT/wXppUJZmBoUaXUPgF0745H3aXc+d6+JDnVRH4RNMpUhItJhU5uOBjnpCtg HGiIsbipeHLfFX1hDXUW/zRTA0AlMOE4kPTgWM8ZvKD8w/A1IaL/44ISRFIKFCvckTQ/xDme XmK/MIIEAjCCAuqgAwIBAgIBADANBgkqhkiG9w0BAQQFADCBkTELMAkGA1UEBhMCRlIxDTAL BgNVBAgTBE5vcmQxGjAYBgNVBAcTEVZpbGxlbmV1dmUgZCdBc2NxMS4wLAYDVQQKEyVORVRB U1EgLSBTZWN1cmUgSW50ZXJuZXQgQ29ubmVjdGl2aXR5MScwJQYDVQQLEx5ORVRBU1EgQ2Vy dGlmaWNhdGlvbiBBdXRob3JpdHkwHhcNMDIwMjE5MTIzNDU1WhcNMjIwMjE0MTIzNDU1WjCB kTELMAkGA1UEBhMCRlIxDTALBgNVBAgTBE5vcmQxGjAYBgNVBAcTEVZpbGxlbmV1dmUgZCdB c2NxMS4wLAYDVQQKEyVORVRBU1EgLSBTZWN1cmUgSW50ZXJuZXQgQ29ubmVjdGl2aXR5MScw JQYDVQQLEx5ORVRBU1EgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkwggEiMA0GCSqGSIb3DQEB AQUAA4IBDwAwggEKAoIBAQDBgE+Let5/q3S24kyiPlHgfuxr5YxJnAOHhceNlXl7o/os5vKu V4Lqg0UNkmuAG0qT1LDN+ed/ibfFzRBL2QoI8sXAumYgrdELHQrhhiL64GusvfjuQfhQ9+sj oq+thwWkbdjAVlQr7stmf9j0dIHqfiC92IKTtyaS4WvWJ8W0NhmqS01Syz3JAI+qHR311d+6 FFXy/KCC9WRx9NlwLJWlFoNhoObSPfRSttrrYqwrF+HpwQC3qSY9TG+IZVqgSKJoAENlVK7o +NLXuoNxlpDOWfCEtpwrIzXNHv6W98VHTf+HqbwlgYE8w/vNxwfa4l+5+H45/cC858IVkVw2 HMcLAgMBAAGjYzBhMB0GA1UdDgQWBBQnKusd2UTaOhdzagkgIMklqPl/sjAfBgNVHSMEGDAW gBQnKusd2UTaOhdzagkgIMklqPl/sjAPBgNVHRMBAf8EBTADAQH/MA4GA1UdDwEB/wQEAwIB BjANBgkqhkiG9w0BAQQFAAOCAQEAlyWoU39apiaFxmVdpuvDoolA2r9MrpMsMfPBlVzKOfRC G6MdGv4RxWloTWkhLh+OzLDOkg0Td970NKULgjPJ6oOrcS0zh5ANJebhhEYtmnxfYzlN1xyb GUSUOBnOVVcw6Wj8SGGHi+rNJtzUzgUR8ROIRX68tfkxpYQcfx2bOUQvrfaY6Z7X1Ak3oFAo k+YIKPVVvEkOslKkXTWRcUlS3KsDSKWsQbSYD4UsWN+xa5lfNgQ+O/X8Ug8yVKcIKJbxlLPC y1BfYGEsSLS6BklGlqRUxj9OR2gsQSti3SaNkP53+hcVHtA3MzEAekMQ+aVlGi0/Vbuw7qSk E/uXKH9hzjGCAnwwggJ4AgEBMIGgMIGRMQswCQYDVQQGEwJGUjENMAsGA1UECBMETm9yZDEa MBgGA1UEBxMRVmlsbGVuZXV2ZSBkJ0FzY3ExLjAsBgNVBAoTJU5FVEFTUSAtIFNlY3VyZSBJ bnRlcm5ldCBDb25uZWN0aXZpdHkxJzAlBgNVBAsTHk5FVEFTUSBDZXJ0aWZpY2F0aW9uIEF1 dGhvcml0eQIKcMaxSBZr8pBq+TAJBgUrDgMCGgUAoIGxMBgGCSqGSIb3DQEJAzELBgkqhkiG 9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTExMDcyMDIyMjU0NVowIwYJKoZIhvcNAQkEMRYEFHHe Sb4GUhMQyzeBAFpyM0BoMfK7MFIGCSqGSIb3DQEJDzFFMEMwCgYIKoZIhvcNAwcwDgYIKoZI hvcNAwICAgCAMA0GCCqGSIb3DQMCAgFAMAcGBSsOAwIHMA0GCCqGSIb3DQMCAgEoMA0GCSqG SIb3DQEBAQUABIIBAMJ1WXX8Jd7DXLLWr9PPGIBtFXfQLBx5sB1QS+6MMdH47qLmR81pq2u0 VhtgEj0PaiF8Yuitxj1R0tRzpfz5xp10RcG2CWAJmYRBqa2/fZ61lYRSGZZSXIITqnQ4MsHz 6Plp5r33mg0DSSklf+vtA0pCMoglnMRPj4JPyHGb0+6Eda1DAkoyQPtaqyygGgQxSS4V0dek uMV2VACVLB7jpbaiHgoptSx8qvtnEEkFPJTJQi+hAeQmdgN6Gril1jD/gdcGxVau1DV7hLtc qshyYuvxp7wwssGiX/IBMo5nL6x4g3PJTZ8NLSD8MQ6+PzFNsAPYh8OBn3qjEh7uLpXftKY= --JP+T4n/bALQSJXh8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110720222545.GB24725>