Date: Wed, 4 Sep 2013 20:03:49 +0200 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com> To: "Justin T. Gibbs" <gibbs@freebsd.org> Cc: "freebsd-xen@freebsd.org" <freebsd-xen@freebsd.org> Subject: Re: Another blkback issue related to flush Message-ID: <52277605.3050204@citrix.com> In-Reply-To: <EAD57817-4430-41AA-B12A-DCDD07A61412@freebsd.org> References: <522768EA.6010809@citrix.com> <EAD57817-4430-41AA-B12A-DCDD07A61412@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/09/13 19:49, Justin T. Gibbs wrote: > On Sep 4, 2013, at 11:07 AM, Roger Pau Monné <roger.pau@citrix.com> wrote: > >> Hello, >> >> I've found another issue with blkback handling of flush operations, it >> was incorrectly setting one of the bio parameters when using a block >> device as backend. The attached patch fixes it, and also includes a >> small fix to correctly set the operation when writing the response on >> the ring (all responses written by FreeBSD blkback were of type >> BLKIF_OP_READ, because nreq->operation was not set). > > It seems that the req's pendcnt is unused and can be culled. Otherwise, > looks good to me. Here's the patch I have in my tree now. Thanks for catching this one. The patch looks OK to me.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52277605.3050204>