Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 20 Oct 2000 17:23:26 +0200 (CEST)
From:      Bernard Steiner <bs@qwerty.eunet.ch>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   kern/22152: typo in ip_fw.c
Message-ID:  <200010201523.RAA53304@qwerty.eunet.ch>

next in thread | raw e-mail | index | archive | help

>Number:         22152
>Category:       kern
>Synopsis:       typo in ip_fw.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 20 08:30:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Bernard Steiner
>Release:        FreeBSD 4.1-RELEASE i386
>Organization:
KPNQwest Switzerland Ltd
>Environment:

	

>Description:

	
/sys/netinet/ip_fw.c about line 175 in 4.1R, 4.1.1R
(and possibly 5.0 current ?) contain the line

SYSCTL_INT(_net_inet_ip_fw, OID_AUTO, dyn_short_lifetime, CTLFLAG_RW,
/*  --------------------------------------^^^^^ */
    &dyn_rst_lifetime, 0, "Lifetime of dyn. rules for other situations");
/*  -----^^^ */

which I believe makes the dynamic ruleset time out pre-maturely.


>How-To-Repeat:

	

>Fix:

	

Looks like a cut-and-paste typo to me. I suggest:

SYSCTL_INT(_net_inet_ip_fw, OID_AUTO, dyn_short_lifetime, CTLFLAG_RW,
    &dyn_short_lifetime, 0, "Lifetime of dyn. rules for other situations");
/*  -----^^^^^ */

but please do check that I am not mistaken :-)

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010201523.RAA53304>