Date: Tue, 22 Dec 2009 15:21:33 -0800 From: Stanislav Sedov <stas@FreeBSD.org> To: d@delphij.net Cc: src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, Stanislav Sedov <stas@FreeBSD.ORG>, Xin LI <delphij@FreeBSD.ORG>, svn-src-head@FreeBSD.ORG, Xin LI <delphij@delphij.net> Subject: Re: svn commit: r200806 - head/usr.sbin/newsyslog Message-ID: <20091222152133.526509ab.stas@FreeBSD.org> In-Reply-To: <4B3143CE.1000608@delphij.net> References: <200912212012.nBLKC2aS039479@svn.freebsd.org> <20091222133217.aad538b0.stas@FreeBSD.org> <4B3143CE.1000608@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Tue__22_Dec_2009_15_21_33_-0800_FQuq+rQ=KhGuhZ2g Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, 22 Dec 2009 14:10:22 -0800 Xin LI <delphij@delphij.net> mentioned: > On 2009/12/22 13:32, Stanislav Sedov wrote: > > On Mon, 21 Dec 2009 20:12:02 +0000 (UTC) > > Xin LI<delphij@FreeBSD.org> mentioned: > > > >> Author: delphij > >> Date: Mon Dec 21 20:12:01 2009 > >> New Revision: 200806 > >> URL: http://svn.freebsd.org/changeset/base/200806 > >> > >> Log: > >> Don't consider non-existence of a PID file an error, we should be a= ble > >> to proceed anyway as this most likely mean that the process has been > >> terminated. > > > > Or the process has not created the PID file and can be screwed up by ro= tating > > its log file. What about making this optional controlled by a command = line > > switch? It might be a more safe alternative. >=20 > Yes probably. I think the both case (can't find the PID file, or the=20 > PID file is empty) should be counted, as they may represent the similar=20 > situation, however, I think we'd better leave the current behavior=20 > default, since it's the most case. >=20 > Do you think the attached patch makes sense? >=20 Yeah, thank you, it looks fine. In my opinion, though, I'd left the old behavior as default, as it is somew= hat safer. But maybe I'm just too paranoic.:-) --=20 Stanislav Sedov ST4096-RIPE --Signature=_Tue__22_Dec_2009_15_21_33_-0800_FQuq+rQ=KhGuhZ2g Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJLMVSCAAoJEL8lojEJL9nwCfgP/RvLoWdiifFAPcB6LkPPv9pl 9ScG60jWTPKA+R67NkoxiBM0v6oOq2qqpluWifx+SgDVsj4gFHdE8Ccm6Oyw7AYo QC5vbarq/NwHQq1cx5iR70kLqPuo6UUI/j6clANp1dMX0QTb2AKoPYT+a9staT3Y hkyVFaI9t9eNW/kDBoNaqPF2V731NkRO098E5CvZK3sxCRwRkBRvJBqxjhE05lM5 PBJUpWWoYpDBjUd8zL2Z33khSlqu/cGJ89eoj16LE5qFYWceLCxdk5rD6ssv1vRK sY6LvjkjcFqjkpq3SXKEhPO1m241d8GD0rAbxZW6Jilpnz5nBe5A1NTW9eM579Zp /Zu4qVq7jGWTMQ5Zgnxn6zES8xg5Rme6D2LFvHJJ9uRt59/mm1iVq62LbQX44SSk 3PoAmM2AyX2IDRxl+lbiLAVs1JLDcCx2NvH/H7DJ0bC0BGE1inNrozNRrYY2/ips as1vB2yg9vtvjHFQOfKdsZfFzJD9+1FZ3aHWV+OYa4sHhYoaSaZ+1GY5XW1URxzo HjTeXdCLEvM+MC5dh9tR65n9IGKGeJPaA6SMkSqRQogLr9j6Gx96ByYMDAMRglAD aL8q/IkUoQaJlIuU4ZAqOJv6rCzt1w2HA4GWDjbQGiThq3OawVbNky73sn5GXvF+ lBsqcaVGaYlOyKowWFWT =sEXE -----END PGP SIGNATURE----- --Signature=_Tue__22_Dec_2009_15_21_33_-0800_FQuq+rQ=KhGuhZ2g--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091222152133.526509ab.stas>