Date: Tue, 25 Apr 2006 02:31:51 +0400 From: Andrey Chernov <ache@FreeBSD.ORG> To: Jeremy Chadwick <freebsd@jdc.parodius.com> Cc: cvs-ports@FreeBSD.ORG, ports-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: ports/graphics/png/files patch-aa Message-ID: <20060424223151.GA23584@nagual.pp.ru> In-Reply-To: <20060424210548.GA80839@pentarou.parodius.com> References: <200604241404.k3OE49eJ074318@repoman.freebsd.org> <20060424180431.GA13567@xor.obsecurity.org> <20060424210548.GA80839@pentarou.parodius.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 24, 2006 at 02:05:48PM -0700, Jeremy Chadwick wrote:
> On Mon, Apr 24, 2006 at 02:04:31PM -0400, Kris Kennaway wrote:
> > On Mon, Apr 24, 2006 at 02:04:09PM +0000, Andrey A. Chernov wrote:
> > > ache 2006-04-24 14:04:09 UTC
> > >
> > > FreeBSD ports repository
> > >
> > > Modified files:
> > > graphics/png/files patch-aa
> > > Log:
> > > Use NO_OBJ NO_PROFILE instead of obsoleted their variants
> > >
> > > PR: 96244
> > > Submitted by: Jeremy Chadwick <freebsd@jdc.parodius.com>
> >
> > Are you sure this works on old FreeBSD branches?
>
> .if ${OSVERSION} < 500000
> MAKE_ARGS+= -DNOPROFILE -DNOOBJ
> .else
> MAKE_ARGS+= -DNO_PROFILE -DNO_OBJ
> .endif
I don't think it deserve such complex tweaking: in worst possible case 4.x
users will additionaly build profiled library too, and since libpng is
small, it will not produce much difference.
--
http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060424223151.GA23584>