Date: Tue, 13 Dec 2016 01:59:35 +0000 (UTC) From: Devin Teske <dteske@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r309973 - head/usr.sbin/bsdinstall/scripts Message-ID: <201612130159.uBD1xZ3b050724@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dteske Date: Tue Dec 13 01:59:35 2016 New Revision: 309973 URL: https://svnweb.freebsd.org/changeset/base/309973 Log: Why use $? when you can use the command itself Modified: head/usr.sbin/bsdinstall/scripts/wlanconfig Modified: head/usr.sbin/bsdinstall/scripts/wlanconfig ============================================================================== --- head/usr.sbin/bsdinstall/scripts/wlanconfig Tue Dec 13 01:56:28 2016 (r309972) +++ head/usr.sbin/bsdinstall/scripts/wlanconfig Tue Dec 13 01:59:35 2016 (r309973) @@ -171,8 +171,7 @@ if ! wpa_cli ping > /dev/null 2>&1; then $DIALOG --backtitle "$DIALOG_BACKTITLE" --title "$msg_error" --msgbox \ "Could not start wpa_supplicant!" 0 0; exit 1 || exit 1 - wpa_cli ping > /dev/null 2>&1 - if [ $? -ne 0 -a ! "$BSDINSTALL_CONFIGCURRENT" ]; then + if ! wpa_cli ping > /dev/null 2>&1 && [ ! "$BSDINSTALL_CONFIGCURRENT" ]; then $DIALOG \ --title "$msg_error" \ --backtitle "$DIALOG_BACKTITLE" \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201612130159.uBD1xZ3b050724>