Date: Sun, 15 Jul 2018 11:03:52 -0700 From: Matthew Macy <mmacy@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Steve Kargl <sgk@troutmask.apl.washington.edu>, Ian Lepore <ian@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [PATCH] Recent libm additions Message-ID: <CAPrugNqXd9ar1Qv3L_ae%2B%2BnmvxOeX1v%2BRqpTf3FVu=0BXm7dvA@mail.gmail.com> In-Reply-To: <CANCZdfrYrz0971Grk5E-hrQd%2BAPZVfNewvDPj19D-T_JZ_1kJw@mail.gmail.com> References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> <CAHM0Q_OMYUe4CDemC8Gx9AGzA%2BwK0cctwUhHieeQi2xdDs0urA@mail.gmail.com> <CANCZdfrYrz0971Grk5E-hrQd%2BAPZVfNewvDPj19D-T_JZ_1kJw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 15, 2018 at 10:55 AM, Warner Losh <imp@bsdimp.com> wrote: > On Sun, Jul 15, 2018, 11:23 AM K. Macy <kmacy@freebsd.org> wrote: > >> > >> > Well, actually, the functions in polevll.c should have been copied >> > into ld80/e_powl.c, and polevall.c should never have been committed. >> > Unfortunately, the code was not reviewed for correctness. >> >> That is not correct. Please stop repeating it. Bruce Evans and John >> Baldwin were both looped in. Neither made this observation. >> > > Steve is the fp guy these days. And it wasn't reviewed by him. He's mad you > cut him out of the loop. Arguing about pedantic points of process does no > one any good. Thanks for the tip. I'm sorry. I was under the impression that he gave up his bit: https://reviews.freebsd.org/rD46886 So we have a maintainer who has opted to not have a bit. So be it. Nonetheless, reviews.freebsd.org is the established channel by which the project does code reviews. I stand by my recommendation and will add him to reviews in the future.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPrugNqXd9ar1Qv3L_ae%2B%2BnmvxOeX1v%2BRqpTf3FVu=0BXm7dvA>