Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Jul 2007 12:13:31 +0200
From:      Christoph Mallon <christoph.mallon@gmx.de>
To:        =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= <des@des.no>
Cc:        src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, bz@freebsd.org, mjacob@freebsd.org, Warner Losh <imp@bsdimp.com>
Subject:   Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c
Message-ID:  <46ADB9CB.501@gmx.de>
In-Reply-To: <86r6mqi4wp.fsf@ds4.des.no>
References:  <20070729214715.I31116@maildrop.int.zabbadoz.net>	<20070729160246.A86779@ns1.feral.com> <86zm1ejrat.fsf@ds4.des.no>	<20070730.025750.41720145.imp@bsdimp.com> <86k5sijlge.fsf@ds4.des.no> <86r6mqi4wp.fsf@ds4.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smørgrav wrote:
> Dag-Erling Smørgrav <des@des.no> writes:
>> The attached patch unbreaks the build.
> 
> With additional hunk to fix usr.bin/netstat/ipx.c, which relied on the
> brokenness of <netinet/tcp_fsm.h>.

Hi,

may I suggest to declare the array as
	static const char * const tcpstates[].
Mind the second const, so not only the strings are const (const char*), 
but the array itself, too.

	Christoph



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46ADB9CB.501>