Date: Tue, 13 Mar 2012 00:17:34 -0500 (CDT) From: "Conrad J. Sabatier" <conrads@cox.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/165993: [patch] missorted SUBDIR in lang/Makefile Message-ID: <201203130517.q2D5HYIf068058@serene.no-ip.org> Resent-Message-ID: <201203130520.q2D5K199098818@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 165993
>Category: ports
>Synopsis: [patch] missorted SUBDIR in lang/Makefile
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Mar 13 05:20:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Conrad J. Sabatier
>Release: FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD serene.no-ip.org 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Sun Feb 12 19:15:46 CST 2012 conrads@serene.no-ip.org:/usr/obj/usr/src/sys/CUSTOM amd64
>Description:
The item "perl5.8" is lexicographically greater than perl5.10, perl5.12
and perl5.14, and should follow, not precede them in the Makefile. I can
understand how such a mistake could easily be made, if one is considering
only the version numbers and mentally performing a numeric sort, but
nonetheless, it should come after.
My "mkreadmes" program helped me spot this, as it left several error
messages in the log file from last night's ports tree update:
Port lang/perl5.10 not found in INDEX
Port lang/perl5.12 not found in INDEX
Port lang/perl5.14 not found in INDEX
Of course these are, in fact, in the index, but mkreadmes relies on
having properly sorted Makefiles as part of its search optimization
strategy. A missorted item will cause it to bypass other items that
should have preceded it.
>How-To-Repeat:
N/A
>Fix:
patch below
--- patch-ports-lang-Makefile begins here ---
Index: ports/lang/Makefile
===================================================================
RCS file: /home/ncvs/ports/lang/Makefile,v
retrieving revision 1.768
diff -u -r1.768 Makefile
--- ports/lang/Makefile 11 Mar 2012 23:52:40 -0000 1.768
+++ ports/lang/Makefile 13 Mar 2012 04:54:46 -0000
@@ -235,10 +235,10 @@
SUBDIR += pbasic
SUBDIR += pcc
SUBDIR += pecl-perl
- SUBDIR += perl5.8
SUBDIR += perl5.10
SUBDIR += perl5.12
SUBDIR += perl5.14
+ SUBDIR += perl5.8
SUBDIR += petite-chez
SUBDIR += pfe
SUBDIR += phantomjs
--- patch-ports-lang-Makefile ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203130517.q2D5HYIf068058>