Date: Wed, 22 Sep 2004 16:53:24 +0000 (UTC) From: Mike Makonnen <mtm@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/lib/libthr/thread thr_mutex.c Message-ID: <200409221653.i8MGrOtw053283@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
mtm 2004-09-22 16:53:24 UTC
FreeBSD src repository
Modified files:
lib/libthr/thread thr_mutex.c
Log:
The SUSv3 function say that the affected functions MAY FAIL, if the
specified mutex is invalid. In spec parlance 'MAY FAIL' means it's
up to the implementor. So, remove the check for NULL pointers for two
reasons:
1. A mutex may be invalid without necessarily being NULL.
2. If the pointer to the mutex is NULL core-dumping in the
vicinity of the problem is much much much better than failing
in some other part of the code (especially when the application
doesn't check the return value of the function that you oh so
helpfully set to EINVAL).
Revision Changes Path
1.31 +6 -27 src/lib/libthr/thread/thr_mutex.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409221653.i8MGrOtw053283>