Date: Thu, 01 Aug 2002 13:19:10 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Mikhail Teterin <mi+mx@aldan.algebra.com> Cc: arch@FreeBSD.org Subject: RE: march/mcpu in bsd.cpu.mk Message-ID: <XFMail.20020801131910.jhb@FreeBSD.org> In-Reply-To: <200208011113.42669.mi%2Bmx@aldan.algebra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01-Aug-2002 Mikhail Teterin wrote:
> Index: bsd.cpu.mk
> ===================================================================
> RCS file: /home/ncvs/src/share/mk/bsd.cpu.mk,v
> retrieving revision 1.15
> diff -U2 -r1.15 bsd.cpu.mk
> --- bsd.cpu.mk 2002/07/31 03:56:03 1.15
> +++ bsd.cpu.mk 2002/08/01 15:09:35
> @@ -11,5 +11,5 @@
> # may tune support for more advanced processors.
>
> -.if !defined(CPUTYPE) || ${CPUTYPE} == ""
> +.if (!defined(CPUTYPE) || ${CPUTYPE} == "") && ${CFLAGS:M-cpu=*} == ""
This doesn't work on non-i386 and assumes too much about what the
contents on _CPU_CFLAGS will be on other archs even if you did fix it to
work with the settings we currently use now. You have no way of knowing
that the user is using some other option that doesn't match that pattern
that conflicts with _CPU_CFLAGS. CPUTYPE is optional, and part of
CPUTYPE are the NO_CPU_CFLAGS and NO_CPU_COPTFLAGS variables which are
very clearly documented right beside CPUTYPE in
/usr/share/examples/etc/make.conf as I have already pointed out to you.
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020801131910.jhb>