Date: Tue, 20 Feb 2007 17:10:59 +0100 From: Max Laier <max@love2party.net> To: Luigi Rizzo <luigi@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/iwi if_iwi.c if_iwivar.h Message-ID: <200702201711.05599.max@love2party.net> In-Reply-To: <200702201545.l1KFjxF8052100@repoman.freebsd.org> References: <200702201545.l1KFjxF8052100@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1587711.O8jXnCBnMp Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 20 February 2007 16:45, Luigi Rizzo wrote: > luigi 2007-02-20 15:45:59 UTC > > FreeBSD src repository > > Modified files: > sys/dev/iwi if_iwi.c if_iwivar.h > Log: > Address a few issues with the iwi driver, namely: =2E.. > + add debugging code IWI_LOCK_ASSERT() to detect missing locks. > These only do a printf, and should go away once we figure out why > the driver sometimes freezes the system due to a (yet unidentified) > race condition. > > + add a device_printf() in iwi_ioctl() in certain conditions > (see comment in the code). This helps preventing the race > condition mentioned above, and makes the system survive. This printf > will also go away once fixing this bug is completed. =2E.. > The bugs fixed by this commit (the freezing one especially) are > serious enough to call for a quick MFC =2E.. but since it is only a stopgap sollution, shouldn't we try to figure= =20 this out in HEAD and MFC the proper sollution once we found it? > MFC after: 3 days > > Revision Changes Path > 1.47 +127 -78 src/sys/dev/iwi/if_iwi.c > 1.13 +20 -0 src/sys/dev/iwi/if_iwivar.h =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart1587711.O8jXnCBnMp Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQBF2x2ZXyyEoT62BG0RAi7uAJsESUCaqtiCpfURY6H1w/lSphE6MgCfUg64 kBv9EPuUPVKGBxdKqeiOT6c= =HBib -----END PGP SIGNATURE----- --nextPart1587711.O8jXnCBnMp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702201711.05599.max>