Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 Oct 2016 09:44:02 -0700
From:      Conrad Meyer <cem@freebsd.org>
To:        Marcel Moolenaar <marcel@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r306620 - head/usr.bin/mkimg
Message-ID:  <CAG6CVpWTDsBFEWd1GDaQZ%2BTnY7Ltw945Wf5T6RwqMeh-G_j_cg@mail.gmail.com>
In-Reply-To: <201610030146.u931klQS063311@repo.freebsd.org>
References:  <201610030146.u931klQS063311@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 2, 2016 at 6:46 PM, Marcel Moolenaar <marcel@freebsd.org> wrote:
> Author: marcel
> Date: Mon Oct  3 01:46:47 2016
> New Revision: 306620
> URL: https://svnweb.freebsd.org/changeset/base/306620
>
> Log:
>   Replace STAILQ with TAILQ. TAILQs are portable enough that they can
>   be used on both macOS and Linux. STAILQs are not. In particular,
>   STAILQ_LAST does not next on Linux. Since neither STAILQ_FOREACH_SAFE
>   nor TAILQ_FOREACH_SAFE exist on Linux, replace its use with a regular
>   TAILQ_FOREACH. The _SAFE variant was only used for having the next
>   pointer in a local variable.

All of these routines are available in the "libbsd" sys/queue.h.  You
might find other helpful portability/compatibility routines there,
requiring fewer changes to the FreeBSD mkimg.

Best,
Conrad



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpWTDsBFEWd1GDaQZ%2BTnY7Ltw945Wf5T6RwqMeh-G_j_cg>