Date: Thu, 15 Sep 2005 09:40:21 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@FreeBSD.org> To: Patrick Bowen <pbowen@fastmail.fm> Cc: Freebsd-current@FreeBSD.org Subject: Re: ATA error on 6.0-BETA4 Message-ID: <2B22BF98-3FF4-4BE5-B8FF-56BB07CDB4D9@FreeBSD.org> In-Reply-To: <4328D0F7.2090501@fastmail.fm> References: <1126047871.687.1.camel@localhost> <E52963F6-A762-4719-A6AD-4412C0011C17@FreeBSD.org> <4328D0F7.2090501@fastmail.fm>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15/09/2005, at 3:40, Patrick Bowen wrote:
> I've notice the same behaviour on my Dell C600. I've attached =20
> verbose dmesg's for -current and 5.4. When I boot 5.4 the CD-RW is =20
> found and I have no problems using it for either reading or =20
> writing. I hope they're useful for you.
OK, please try the below patch and let me know if that helps any.
> I'd like to say that I have the greatest respect for *all* of you =20
> that work at making FreeBSD the great OS that it is. I just wonder =20
> where you find the time to work on it, what with your day jobs, =20
> family responsibilities and all...
I guess we have understanding environments and need for less sleep =20
than usual :)
Index: ata-lowlevel.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/src/sys/dev/ata/ata-lowlevel.c,v
retrieving revision 1.71
diff -u -r1.71 ata-lowlevel.c
--- ata-lowlevel.c 14 Sep 2005 12:45:06 -0000 1.71
+++ ata-lowlevel.c 15 Sep 2005 07:35:41 -0000
@@ -278,7 +278,7 @@
/* if read data get it */
if (request->flags & ATA_R_READ) {
- if (ata_wait(ch, atadev, (ATA_S_READY | ATA_S_DRQ)) < =20=
0) {
+ if (ata_wait(ch, atadev, ATA_S_DRQ) < 0) {
device_printf(request->dev,
"timeout waiting for read DRQ\n");
request->result =3D EIO;
S=F8ren Schmidt
sos@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2B22BF98-3FF4-4BE5-B8FF-56BB07CDB4D9>