Date: Wed, 5 Mar 2003 20:39:56 +0100 From: Anton Berezin <tobez@tobez.org> To: Kris Kennaway <kris@obsecurity.org> Cc: Jun Kuriyama <kuriyama@imgsrc.co.jp>, freebsd-ports@FreeBSD.org Subject: Re: Knob for perllocal.pod Message-ID: <20030305193956.GA8460@heechee.tobez.org> In-Reply-To: <20030221022238.GA8145@rot13.obsecurity.org> References: <7mel62bjqv.wl@black.imgsrc.co.jp> <20030221022238.GA8145@rot13.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 20, 2003 at 06:22:38PM -0800, Kris Kennaway wrote:
> On Fri, Feb 21, 2003 at 08:44:08AM +0900, Jun Kuriyama wrote:
> >
> > For Kris. :-)
> >
> > I don't know which option is better.
> >
> > (1) Add knob like below.
> > pros: will not do (bad) effect other PERL_CONFIGURE ports unless
> > knob is set.
> > cons: requires to add knobs to all ports which has perllocal.pod.
> >
> > (2) Add reinplace inside of .if defined(PERL_CONFIGURE) and doing this
> > implicitly if $PERL_CONFIGURE is defined.
> > pros: does not need to touch Makefile of each ports. Only plist fix
> > is required.
> > cons: may cause some problems (I don't think so, but I don't know
> > there is a program which uses perllocal.pod file).
It is supposed to be used for de-installation, but currently there is no
deinstall target anywhere. Besides, the ports collection handles
de-installation mostly fine. So it can be safely removed.
Another IMO important cons is the multitude of perllocal.pod-* files in
${PREFIX}/lib, which is undesirable.
> Thanks very much! I'll test (2) on bento as soon as I can.
I would suggest the complete removal instead:
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.441
diff -u -r1.441 bsd.port.mk
--- bsd.port.mk 2 Mar 2003 02:06:56 -0000 1.441
+++ bsd.port.mk 5 Mar 2003 19:36:04 -0000
@@ -2722,7 +2722,7 @@
${SETENV} ${CONFIGURE_ENV} \
${PERL5} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS}
@cd ${CONFIGURE_WRKSRC} && \
- ${REINPLACE_CMD} -e 's/perllocal.pod/&-${PORTNAME}/' Makefile
+ ${PERL5} -pi -e 's/ doc_(perl|site)_install$$//' Makefile
.endif
.if defined(USE_IMAKE)
@(cd ${CONFIGURE_WRKSRC}; ${SETENV} ${MAKE_ENV} ${XMKMF})
--
It's a short step from "rigor" to "rigor mortis". -- Chip Salzenberg
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030305193956.GA8460>