Date: Tue, 27 Sep 2016 23:58:02 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: marino@freebsd.org, Vsevolod Stakhov <vsevolod@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r422826 - head/security/libsodium Message-ID: <2acdea56-9c02-4ea9-943c-7a5091ca49ab@FreeBSD.org> In-Reply-To: <b23328e4-1adb-177d-5e88-e43588c56a1b@marino.st> References: <201609271943.u8RJhXe0061946@repo.freebsd.org> <6d763b2f-0745-9f7a-c94e-b9653174bdd5@marino.st> <f67dca1b-3249-fca0-2113-ac440dd4346e@FreeBSD.org> <b23328e4-1adb-177d-5e88-e43588c56a1b@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6AudibkidL1KMgxhuccOo5D6sDc0uAmme Content-Type: multipart/mixed; boundary="q0rh8To6j36bdSpA2QlPK0kBhvTbQBEfj"; protected-headers="v1" From: Mathieu Arnold <mat@FreeBSD.org> To: marino@freebsd.org, Vsevolod Stakhov <vsevolod@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <2acdea56-9c02-4ea9-943c-7a5091ca49ab@FreeBSD.org> Subject: Re: svn commit: r422826 - head/security/libsodium References: <201609271943.u8RJhXe0061946@repo.freebsd.org> <6d763b2f-0745-9f7a-c94e-b9653174bdd5@marino.st> <f67dca1b-3249-fca0-2113-ac440dd4346e@FreeBSD.org> <b23328e4-1adb-177d-5e88-e43588c56a1b@marino.st> In-Reply-To: <b23328e4-1adb-177d-5e88-e43588c56a1b@marino.st> --q0rh8To6j36bdSpA2QlPK0kBhvTbQBEfj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 27/09/2016 =C3=A0 23:50, John Marino a =C3=A9crit : > On 9/27/2016 16:14, Mathieu Arnold wrote: >> Le 27/09/2016 =C3=A0 21:51, John Marino a =C3=A9crit : >>> On 9/27/2016 14:43, Vsevolod Stakhov wrote: >>>> Author: vsevolod >>>> Date: Tue Sep 27 19:43:32 2016 >>>> New Revision: 422826 >>>> URL: https://svnweb.freebsd.org/changeset/ports/422826 >>>> >>>> Log: >>>> - Update to 1.0.11 >>>> >>>> No bump for dependent port is required as this version has no API >>>> changes >>>> >>>> >>>> Modified: head/security/libsodium/pkg-plist >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>> >>>> >>>> --- head/security/libsodium/pkg-plist Tue Sep 27 18:25:34 2016 >>>> (r422825) >>>> +++ head/security/libsodium/pkg-plist Tue Sep 27 19:43:32 2016 >>>> (r422826) >>>> @@ -58,7 +58,7 @@ include/sodium/version.h >>>> lib/libsodium.a >>>> lib/libsodium.so >>>> lib/libsodium.so.18 >>>> -lib/libsodium.so.18.1.0 >>>> +lib/libsodium.so.18.1.1 >>>> libdata/pkgconfig/libsodium.pc >>>> %%PORTDOCS%%%%DOCSDIR%%/AUTHORS >>>> %%PORTDOCS%%%%DOCSDIR%%/README.markdown >>>> >>> >>> First, I don't think the "no API change" means a bump is not mandator= y. >>> Secondly, the SO name of the library changed!!! You have to bump it,= >>> there's no question here. >>> >>> It's 1000x better to bump unnecessarily than to skip a bump that is >>> required. >> >> No it did not. >> >> $ readelf -d `make -V STAGEDIR`/usr/local/lib/libsodium.so|grep soname= >> 0x000000000000000e SONAME Library soname: >> [libsodium.so.18] >> >> The file name changed, but software will try to find libsodium.so.18, >> and that will still work. >> > > regardless, why should the bump be avoided? > There could have been fixes against the existing functions. > > I'm starting to see a lot of people go out of their way to bump and I > don't know where the trend is coming from. > > Is portmgr saying vsevolod is correct not to bump this? I would bump > it and if that's wrong maybe my bump criteria is wrong. You have to bump ports that depend on a .so when the soname changes. For= example, if the libsodium update had done this: lib/libsodium.so -lib/libsodium.so.18 -lib/libsodium.so.18.1.0 +lib/libsodium.so.19 +lib/libsodium.so.19.2.1 You would have needed to bump, because the soname would have changed from= libsodium.so.18 to libsodium.so.19, and software built with the old vers= ion would have tried to load the .18 lib that did not exist any more. As a general rule, when you don't know what to do, don't do what you gues= sed, ask. There are people with more knowledge than you, and they can ex= plain you what you are doing wrong. =20 --=20 Mathieu Arnold --q0rh8To6j36bdSpA2QlPK0kBhvTbQBEfj-- --6AudibkidL1KMgxhuccOo5D6sDc0uAmme Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJX6utrXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I3fcP/1bnhFgdYLYUxlAsEk+bkXsT KERYBlc3JjVQbIMvuh29fTF32MmGETMqd2NpTghWkjMgoJ4+0TN9Kt8GpawTjZd8 ZPY50FfC6ucKx2ks7kUN/1O2z/CjyES9pns+YAk3+JmkBXTbAn1uiEAUGspou6lu CCXFc+qVUDAnIStoPBGerMkfmB7NkiWijJuyqpjIlMTr8Xp1pGyRMcSPbika2pPb SFj4urNdjt+qHEe6ImSCwVxpr4pBkRi1LyJUoD099CO2OYrsNPTIPKclu7qgvFvI VQ58kqFHX5lff61/FLhAKDxwu02r+LFwZc4JbOJxLMq/rB9GZ3EY4w7hjeYgEKAk TyAaS1OU8Mo7Vz6CNqk9djRqThODFjvkpmbRuOL7U7NxirbNveZiQ9NnnhixaPOR 4HsJNyx67Fy38Fc/CNS3oSGbuxEY/c4NBD/0F1rjvU6SFaPbaZDNC4RB8e6NJmGf mZR6xQtajEFd9oxnGFX6xPAOZ2DWSdmz2OoB17qdRWvaZuvu42yyuAKBp08vEKxf kF3s33AlivAyCitwSZNXEf4Pqx0deszY369Vl6/qABEUFryqhI3ya8+86SopRWpi p16BW7CvjtYs3H85aVIZUUTqAz1Hs8TnD49DXsYb0MTsv5gXMAIqVSoMeH7CcJ5X r7mJxLTGsBaJUU63XMXj =A28B -----END PGP SIGNATURE----- --6AudibkidL1KMgxhuccOo5D6sDc0uAmme--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2acdea56-9c02-4ea9-943c-7a5091ca49ab>