Date: Mon, 29 Jul 2019 07:57:41 +0200 From: Tobias Kortkamp <tobik@freebsd.org> To: Gleb Popov <arrowd@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r507361 - head/Mk/Uses Message-ID: <20190729055741.GA35501@urd.tobik.me> In-Reply-To: <CALH631ntL8XYkYreYUD609xetNaGYdHO3g3Yw3c2SL-xWk346g@mail.gmail.com> References: <201907261652.x6QGqoxC018196@repo.freebsd.org> <20190727055121.GA99138@urd.tobik.me> <CALH631ntL8XYkYreYUD609xetNaGYdHO3g3Yw3c2SL-xWk346g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 28, 2019 at 02:19:30PM +0400, Gleb Popov wrote: > On Sat, Jul 27, 2019 at 9:51 AM Tobias Kortkamp <tobik@freebsd.org> wrote: >=20 > > On Fri, Jul 26, 2019 at 04:52:50PM +0000, Gleb Popov wrote: > > > Author: arrowd > > > Date: Fri Jul 26 16:52:49 2019 > > > New Revision: 507361 > > > URL: https://svnweb.freebsd.org/changeset/ports/507361 > > > > > > Log: > > > Add support for USES=3D cabal:hpack and document this option. > > > > > > Modified: > > > head/Mk/Uses/cabal.mk > > > > > > Modified: head/Mk/Uses/cabal.mk > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/Mk/Uses/cabal.mk Fri Jul 26 16:46:46 2019 (r50736= 0) > > > +++ head/Mk/Uses/cabal.mk Fri Jul 26 16:52:49 2019 (r50736= 1) > > > @@ -2,9 +2,13 @@ > > > # > > > # Provide support for building Haskell packages using Cabal. > > > # > > > -# Feature: cabal > > > -# Usage: USES=3Dcabal > > > +# Feature: cabal > > > +# Usage: USES=3Dcabal or USES=3Dcabal:ARGS > > > +# Valid ARGS: hpack > > > # > > > +# hpack: The port doesn't have a .cabal file and needs > > devel/hs-hpack to > > > +# generate it from package.yaml file > > > +# > > > # Variables, which can be set by the port: > > > # > > > # USE_CABAL List of Haskell packages required to build a po= rt. > > > @@ -36,10 +40,6 @@ > > > .if !defined(_INCLUDE_USES_CABAL_MK) > > > _INCLUDE_USES_CABAL_MK=3D yes > > > > > > -.if !empty(cabal_ARGS) > > > -IGNORE=3D Incorrect 'USES=3D cabal:${cabal_ARGS}' cabal= takes > > no arguments > > > -.endif > > > - > > > > Nothing checks USES=3Dcabal args now and it accepts any garbage > > arguments like USES=3Dcabal:asdfasd. Please put back some check for > > invalid arguments. > > >=20 > Does https://svnweb.freebsd.org/changeset/ports/507506 look good for you? It's ok. Thanks. The error message could be better though. It flags 'hpack' as invalid with something like USES=3Dcabal:hpack,foo "USES=3Dcabal: invalid arguments: hpack foo" 'hpack' is not an invalid argument here, only 'foo' is. --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl0+itBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2Fh5wgAspWgd1EKCJq6RMs4hXTOlA7hd0gos5miDD6e74nWdghrNo61VGaobv0T GZDR5R+XUJQ4NsOUZP42cdECtpzPb6bFyX4fu1SGVkesyVkK5uy2wPrguCwwerb1 aO/MnJTUcS23vJoOvwdNO6IFmds6pWkWuXCHpXWQqrj5dEL6QcG+b5DW8+yPbq09 zwCRcl9EiEQ3E09PnUBH/G0g4hifCzoDW54bovOG3qIWO8fKJgTsljo+c+dlU0mW R809tpqpQUPFNRJkWuX40HVoc006ou38jeXvdwK1/5Tp/0zYPClvIt2JTe/mxody HaZ6H2ZFCDBcjDVdb81hjXmZ5S4RjQ== =NoCe -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190729055741.GA35501>