Date: 13 Jan 2003 19:06:09 -0800 From: "Gary W. Swearingen" <swear@attbi.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/47036: bsd.port.mk has bad comments WRT dependencies. Message-ID: <xo8yxowhum.yxo@localhost.localdomain>
next in thread | raw e-mail | index | archive | help
>Number: 47036
>Category: ports
>Synopsis: bsd.port.mk has bad comments WRT dependencies.
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Jan 13 19:10:01 PST 2003
>Closed-Date:
>Last-Modified:
>Originator: Gary W. Swearingen
>Release: FreeBSD 4.7-STABLE i386
>Organization:
none
>Environment:
n/a
================
>Description:
A few problems:
1) In several places "depends to" should be "depends on to".
2) The file confusingly misuses the words "dependency" and
"dependencies". A dependency is something dependent, i.e., something
which depends on some other thing. The file has it backwards. The
things in the _DEPENDS variables are not dependencies because they are
not dependent on the port being made. The port being "made" is the only
dependency; it depends on the _DEPENDS ports. I guess it could be said
that those ports are required requirements.
3) The "clean" target description should say that it also cleans
required ports, by default.
4) Missing a hyphen.
================
>How-To-Repeat:
n/a
================
>Fix:
Note that "a dependency list" is not necessarily a list of dependencies;
it can be a list related to dependency, so I left the term alone.
Patch this:
# $FreeBSD: ports/Mk/bsd.port.mk,v 1.429 2002/11/10 22:54:25 alane Exp $
with this:
--- /tmp/bsd.port.mk..orig Mon Jan 13 18:43:07 2003
+++ /tmp/bsd.port.mk Mon Jan 13 18:58:53 2003
@@ -203,7 +203,7 @@
# Use this if you need to replace "#!" lines in scripts.
# PERL_VERSION - Full version of perl5 (see below for current value).
# PERL_VER - Short version of perl5 (see below for current value).
-# PERL_ARCH - Directory name of architecture dependent libraries
+# PERL_ARCH - Directory name of architecture-dependent libraries
# (value: ${ARCH}-freebsd).
# USE_BISON - Says that the port uses bison for building.
# USE_IMAKE - Says that the port uses imake. Implies USE_X_PREFIX.
@@ -218,7 +218,7 @@
# not in the list above.
#
# FETCH_DEPENDS - A list of "path:dir[:target]" tuples of other ports this
-# package depends in the "fetch" stage. "path" is the
+# package depends on in the "fetch" stage. "path" is the
# name of a file if it starts with a slash (/), an
# executable otherwise. make will test for the
# existence (if it is a full pathname) or search for
@@ -227,16 +227,16 @@
# found. If the third field ("target") exists, it will
# be used instead of ${DEPENDS_TARGET}.
# BUILD_DEPENDS - A list of "path:dir[:target]" tuples of other ports this
-# package depends to build (between the "extract" and
+# package depends on to build (between the "extract" and
# "build" stages, inclusive). The test done to
-# determine the existence of the dependency is the
+# determine the existence of the required port is the
# same as FETCH_DEPENDS. If the third field ("target")
# exists, it will be used instead of ${DEPENDS_TARGET}.
# RUN_DEPENDS - A list of "path:dir[:target]" tuples of other ports this
-# package depends to run. The test done to determine
-# the existence of the dependency is the same as
+# package depends on to run. The test done to determine
+# the existence of the required port is the same as
# FETCH_DEPENDS. This will be checked during the
-# "install" stage and the name of the dependency will
+# "install" stage and the name of the required port will
# be put into the package as well. If the third field
# ("target") exists, it will be used instead of
# ${DEPENDS_TARGET}.
@@ -250,7 +250,7 @@
# If the second field ("target") exists, it will be used
# instead of ${DEPENDS_TARGET}.
# DEPENDS_TARGET - The default target to execute when a port is calling a
-# dependency (default: "install").
+# required port (default: "install").
#
# Various directory definitions and variables to control them.
# You rarely need to redefine any of these except WRKSRC and NO_WRKSUBDIR.
@@ -330,7 +330,7 @@
# into ${DISTDIR} as necessary.
# fetch-list - Show list of files that would be retrieved by fetch.
# fetch-recursive - Retrieves ${DISTFILES} (and ${PATCHFILES} if defined),
-# for port and dependencies into ${DISTDIR} as necessary.
+# for port and required ports into ${DISTDIR} as necessary.
# fetch-recursive-list - Show list of files that would be retrieved by
# fetch-recursive.
# extract - Unpacks ${DISTFILES} into ${WRKDIR}.
@@ -349,10 +349,11 @@
# give incorrect results if multiple patches deal with
# the same file.
# checksum - Use distinfo to ensure that your distfiles are valid.
-# checksum-recursive - Run checksum in this port and all dependencies.
+# checksum-recursive - Run checksum in this port and all required ports.
# makesum - Generate distinfo (only do this for your own ports!).
# clean - Remove ${WRKDIR} and other temporary files used for building.
-# clean-depends - Do a "make clean" for all dependencies.
+# Also cleans required ports, by default.
+# clean-depends - Do a "make clean" for all required ports.
#
# Default sequence for "all" is: fetch checksum extract patch configure build
#
@@ -518,7 +519,7 @@
# NO_PKG_REGISTER - Don't register a port installation as a package.
# FORCE_PKG_REGISTER - If set, it will overwrite any existing package
# registration information in ${PKG_DBDIR}/${PKGNAME}.
-# NO_DEPENDS - Don't verify build of dependencies.
+# NO_DEPENDS - Don't verify build of required ports.
# NO_CHECKSUM - Don't verify the checksum. Typically used when
# when you noticed the distfile you just fetched has
# a different checksum and you intend to verify if
@@ -1199,7 +1200,7 @@
# do something.
DO_NADA?= ${TRUE}
-# Use this as the first operand to always build dependency.
+# Use this as the first operand to always build required port.
NONEXISTENT?= /nonexistent
# Miscellaneous overridable commands:
@@ -3389,7 +3390,7 @@
.if !target(checksum-recursive)
checksum-recursive:
- @${ECHO_MSG} "===> Fetching and checking checksums for ${PKGNAME} and dependencies"
+ @${ECHO_MSG} "===> Fetching and checking checksums for ${PKGNAME} and required ports"
@for dir in ${.CURDIR} $$(${ALL-DEPENDS-LIST}); do \
(cd $$dir; ${MAKE} checksum); \
done
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xo8yxowhum.yxo>