Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Apr 2010 08:32:08 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r206699 - stable/8/sys/kern
Message-ID:  <201004160832.o3G8W8JH069918@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Fri Apr 16 08:32:08 2010
New Revision: 206699
URL: http://svn.freebsd.org/changeset/base/206699

Log:
  MFC r206546:
  Remove XXX comment. Add another comment, describing why f_vnode assignment
  is useful.

Modified:
  stable/8/sys/kern/vfs_syscalls.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)
  stable/8/sys/dev/xen/xenpci/   (props changed)

Modified: stable/8/sys/kern/vfs_syscalls.c
==============================================================================
--- stable/8/sys/kern/vfs_syscalls.c	Fri Apr 16 07:02:28 2010	(r206698)
+++ stable/8/sys/kern/vfs_syscalls.c	Fri Apr 16 08:32:08 2010	(r206699)
@@ -1124,7 +1124,12 @@ kern_openat(struct thread *td, int fd, c
 	NDFREE(&nd, NDF_ONLY_PNBUF);
 	vp = nd.ni_vp;
 
-	fp->f_vnode = vp;	/* XXX Does devfs need this? */
+	/*
+	 * Store the vnode, for any f_type. Typically, the vnode use
+	 * count is decremented by direct call to vn_closefile() for
+	 * files that switched type in the cdevsw fdopen() method.
+	 */
+	fp->f_vnode = vp;
 	/*
 	 * If the file wasn't claimed by devfs bind it to the normal
 	 * vnode operations here.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201004160832.o3G8W8JH069918>