Date: Wed, 29 Dec 2004 21:17:52 -0500 From: Chuck Swiger <cswiger@mac.com> To: Joshua Lokken <joshua.lokken@gmail.com> Cc: freebsd-chat@freebsd.org Subject: Re: less -f Message-ID: <41D36550.4080900@mac.com> In-Reply-To: <bc5b63850412291803491bc14e@mail.gmail.com> References: <bc5b638504122913577a3faec1@mail.gmail.com> <41D35547.5070105@mac.com> <bc5b63850412291803491bc14e@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Joshua Lokken wrote: > On Wed, 29 Dec 2004 20:09:27 -0500, Chuck Swiger <cswiger@mac.com> wrote: [ ... ] >>You're right, the manpage says and what the program actually does contradict >>each other. Consider the following change to /usr/src/contrib/less: >> >>--- filename.c~ Thu Jun 29 21:03:08 2000 >>+++ filename.c Wed Dec 29 20:04:06 2004 >>@@ -954,10 +954,14 @@ >> { >> static char is_dir[] = " is a directory"; >> >>- m = (char *) ecalloc(strlen(filename) + sizeof(is_dir), >>- sizeof(char)); >>- strcpy(m, filename); >>- strcat(m, is_dir); >>+ if (force_open) { >>+ m = NULL; >>+ } else { >>+ m = (char *) ecalloc(strlen(filename) + sizeof(is_dir), >>+ sizeof(char)); >>+ strcpy(m, filename); >>+ strcat(m, is_dir); >>+ } >> } else >> { > > Is this something that warrants a send-pr? I've never used the > tool, and don't want to generate needless problem reports. > What's the best way to handle it? Thanks for any advice. I have forwarded your problem description and the patch on to <bug-less@gnu.org>, so it can be considered by the author of less. It might be reasonable to send-pr this as well, if you would like to see FreeBSD adopt the fix in a shorter timeframe. -- -Chuck
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41D36550.4080900>