Date: Mon, 13 Jun 2005 10:22:24 -0400 From: "PSI, Mike Smith" <mlsmith@mitre.org> To: <gtg062h@mail.gatech.edu>, <freebsd-net@freebsd.org>, <freebsd-pf@freebsd.org> Subject: Re: Carp Suppression Message-ID: <05e001c57023$5189d180$1b321d80@MITRE.ORG> References: <7c8f2792050610090049064e11@mail.gmail.com> <7c8f279205061116021f55e8da@mail.gmail.com> <7c8f279205061307103b1782f4@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hey all, Honestly I have no idea what this is all about, but saw something in the change adding "ipf->if_flags=LINK_STATE_UP;" that just seemed really strange from a programming standpoint. Doesn't this statement "undo" the effects of the line just before it (ipf->if_flags |= IFF_RUNNING). Again I have no idea what this is about so it is possible that IFF_RUNNING bit(s) is part of LINK_STATE_UP bit(s). Just seemed strange and if this is a problem, catching it early is better than late. If it is correct as stands, I apologize for questioning it. Mike Smith >----- Original Message ----- >From: "Josh Kayse" <josh.kayse@gmail.com> > > One last comment, > > I managed to fix it so that carp runs on the plip interface by adding: > ifp->if_flags = LINK_STATE_UP; > Here is the diff: > diff -Nur /usr.orig/src/sys/dev/ppbus/if_plip.c /usr/src/sys/dev/ppbus/if_plip.c > --- /usr.orig/src/sys/dev/ppbus/if_plip.c Wed Sep 15 11:14:18 2004 > +++ /usr/src/sys/dev/ppbus/if_plip.c Mon Jun 13 10:05:56 2005 > @@ -359,6 +359,7 @@ > > ppb_wctr(ppbus, IRQENABLE); > ifp->if_flags |= IFF_RUNNING; > + ifp->if_flags = LINK_STATE_UP; > } > break;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?05e001c57023$5189d180$1b321d80>