Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 May 2005 18:43:53 +0300
From:      Vasil Dimov <vd@datamax.bg>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   docs/81208: Inconsistency between bsd.port.mk and porters-handbook for LIB_DEPENDS
Message-ID:  <20050518154353.GA28768@sinanica.bg.datamax>
Resent-Message-ID: <200505181550.j4IFo1Uk019524@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         81208
>Category:       docs
>Synopsis:       Inconsistency between bsd.port.mk and porters-handbook for LIB_DEPENDS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 18 15:50:01 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Vasil Dimov
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
DataMax
>Environment:

System: FreeBSD sinanica.bg.datamax 5.4-STABLE FreeBSD 5.4-STABLE #6: Tue May 10 12:46:25 EEST 2005     root@sinanica.bg.datamax:/usr/obj/usr/src/sys/SINANICA-SMP  i386

>Description:

Porters-handbook states that lib part in LIB_DEPENDS (in ports'
Makefiles) is passed as argument to the command:
ldconfig -r | grep -wF
which is incorrect, especially the -F flag and the state that it
may not contain regular expressions.

In bsd.port.mk
ldconfig -r | grep -vwF -e "${PKGCOMPATDIR}" | grep -qwE -e "-l$pattern"
is used and I think that grep -vwF -e "${PKGCOMPATDIR}" and the -q flag
to the second grep call can be omitted for simplicity.
$pattern is lib part of LIB_DEPENDS with dots escaped.

>How-To-Repeat:

>Fix:

--- book.sgml.patch begins here ---
--- book.sgml.orig	Wed May 18 18:03:46 2005
+++ book.sgml	Wed May 18 18:34:26 2005
@@ -3033,9 +3033,11 @@
 	    <literal>install</literal>).</para>
 
 	  <note>
-	    <para>The <replaceable>lib</replaceable> part is an argument given
-	      to <command>ldconfig -r | grep -wF</command>.  There shall be no
-	      regular expressions in this variable.</para>
+	    <para>Library existence is checked with command:
+	    <command>ldconfig -r | grep -wE -e "-l$pattern"</command>.
+	    Where <replaceable>$pattern</replaceable> is the
+	    <replaceable>lib</replaceable> part of <makevar>LIB_DEPENDS</makevar>
+	    with dots (.) escaped (\.).</para>
 	  </note>
 
 	  <para>The dependency is checked twice, once from within the
--- book.sgml.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050518154353.GA28768>