Date: Tue, 03 Dec 2019 14:12:19 -0700 From: Ian Lepore <ian@freebsd.org> To: Ryan Libby <rlibby@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355137 - head/sys/vm Message-ID: <a7ee1944d25babe88a4600731bb231ede35e76e1.camel@freebsd.org> In-Reply-To: <CAHgpiFzjhvAHnbqcynpAc4d%2BewAgrGAcn-V9zyqHeb19YuH7kg@mail.gmail.com> References: <201911271949.xARJnuFl084178@repo.freebsd.org> <20191203204313.GB2706@FreeBSD.org> <CAHgpiFzjhvAHnbqcynpAc4d%2BewAgrGAcn-V9zyqHeb19YuH7kg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2019-12-03 at 12:59 -0800, Ryan Libby wrote: > > + * XXX UMA_ZONE_OFFPAGE. All over freebsd we have cryptic XXX comments that have no meaning to anyone except whoever wrote them (and, I suspect, no meaning to those people either after a couple months have elapsed). To the degree that XXX represents "possible trouble here" and/or "more work to do here", I would argue that any placement of a new XXX requires at least a sentence (and probably more like a paragraph) to describe why it's there. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a7ee1944d25babe88a4600731bb231ede35e76e1.camel>