Date: Wed, 31 Jul 2019 12:52:01 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350005 - head/sys/kern Message-ID: <df2c19b0-f24f-11f6-1067-103056dd2301@FreeBSD.org> In-Reply-To: <20190731194252.GO2731@kib.kiev.ua> References: <201907151918.x6FJIPFo077975@repo.freebsd.org> <d281e1dc-1931-20a5-9f41-7c1f66d4f667@FreeBSD.org> <20190730231256.GL2731@kib.kiev.ua> <20190730232714.GM2731@kib.kiev.ua> <5d3ffe05-58f3-ea26-13ed-51cdcd1deeaa@FreeBSD.org> <20190731051452.GN2731@kib.kiev.ua> <46c7a7bc-29ec-6176-0ede-96ac91984589@FreeBSD.org> <20190731194252.GO2731@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --I6yGNG63gVSSbsCdCYtonEzBGlneRWRxu Content-Type: multipart/mixed; boundary="zfMwmzsDNvVF8e5UjDAdbGjinUa1GeAHQ"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <df2c19b0-f24f-11f6-1067-103056dd2301@FreeBSD.org> Subject: Re: svn commit: r350005 - head/sys/kern References: <201907151918.x6FJIPFo077975@repo.freebsd.org> <d281e1dc-1931-20a5-9f41-7c1f66d4f667@FreeBSD.org> <20190730231256.GL2731@kib.kiev.ua> <20190730232714.GM2731@kib.kiev.ua> <5d3ffe05-58f3-ea26-13ed-51cdcd1deeaa@FreeBSD.org> <20190731051452.GN2731@kib.kiev.ua> <46c7a7bc-29ec-6176-0ede-96ac91984589@FreeBSD.org> <20190731194252.GO2731@kib.kiev.ua> In-Reply-To: <20190731194252.GO2731@kib.kiev.ua> --zfMwmzsDNvVF8e5UjDAdbGjinUa1GeAHQ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/31/19 12:42 PM, Konstantin Belousov wrote: > On Wed, Jul 31, 2019 at 10:08:39AM -0700, Bryan Drewery wrote: >> On 7/30/19 10:14 PM, Konstantin Belousov wrote: >>> No, you should create a situation where the python process ends the e= ndless >>> loop, as reported. Then, it should become killable by 9 with the fir= st >>> chunk only applied. >>> >> >> I don't have an easy way to test that. kill -9 inside the loop didn't >> work. Once the loop ended the process was done; it is very short lived= >> and the calling code is buried in Python I think. > With only the umtxq_check_susp() chunk applied, you would wait for > python to start looping, then verify that kill -9 works. >=20 > Anyway, I believe that the change is correct, and put the review at > https://reviews.freebsd.org/D21124. I will commit after it get some > sanity checking by mentioned people. >=20 Right. I did that earlier and it did not work. I can try again shortly. --=20 Regards, Bryan Drewery --zfMwmzsDNvVF8e5UjDAdbGjinUa1GeAHQ-- --I6yGNG63gVSSbsCdCYtonEzBGlneRWRxu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAl1B8WEACgkQNddxu25G l8+CDQf/ct3ZkblqFZjQh/iI2n4IjyCIcBzpeELKXOB23+J8lkAYp7CUlojQkEj/ ILqsj6EEMT5I2jbky7fZ3818dathQP5KvkfcByz4vhmpX7EFdKp82ylkxrR9rs1N 42i7VOPj67dtS9py6Dss8od7pMVWTPoyuZ6IsCI+pLTglzsS8E0arNieoPDXt65X zO8PFVPlq5nbZdXojUmfkBbDhhMBuvpJvDNrkLDjc557aTtuzVOIGAC4Yj77GQFA fzFeggYtUfOGfBSiIkL89cycjQ9qe3kiXoWd2uesr806kuilG/iOITuPrfQ4f+kz Of9dEM3Q0EY1e9S/C5XyQxDfUt4Jkw== =6vY7 -----END PGP SIGNATURE----- --I6yGNG63gVSSbsCdCYtonEzBGlneRWRxu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?df2c19b0-f24f-11f6-1067-103056dd2301>