Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Jun 2008 10:47:31 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        Poul-Henning Kamp <phk@phk.freebsd.dk>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src Makefile 
Message-ID:  <20080617103603.W83875@maildrop.int.zabbadoz.net>
In-Reply-To: <75185.1213698178@critter.freebsd.dk>
References:  <75185.1213698178@critter.freebsd.dk>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 17 Jun 2008, Poul-Henning Kamp wrote:

> In message <200806170911.m5H9BncF010061@repoman.freebsd.org>, "Bjoern A. Zeeb"
> writes:
>> bz          2008-06-17 09:06:46 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    .                    Makefile
>>  Log:
>>  SVN rev 179842 on 2008-06-17 09:06:46Z by bz
>>
>>  For make universe, in addition to make.conf, also ignore a
>>  src.conf with possibe non-default options.
>
> Actually, that was deliberately not ignored to make it possible
> to test nonstandard trees with universe also.

Okay. I am not sure how it worked in the old make.conf only days.

I usually forget that I do have a per machine /etc/src.conf until the
next morning, thus nightly universe do not help me before committing
because it doesn't give me the builds that everyone else/the tb is
building. And we are still setting __MAKE_CONF to /dev/null thus any
private CFLAGS etc. cannot be tested this way either.

Maybe we need a better overall solution?

I have no idea if we can implement it only for universe but what about
something like this?
- do not pre-define __MAKE_CONF/SRCCONF for universe
- if __MAKE_CONF/SRCCONF is not defined manually (env) we'll ingore it
   (it's not set)
- if it is defined (env) use it


-- 
Bjoern A. Zeeb              Stop bit received. Insert coin for new game.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080617103603.W83875>