Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Jun 2000 04:00:09 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Peter Wemm <peter@netplex.com.au>
Cc:        Mike Smith <msmith@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin/quot quot.c 
Message-ID:  <Pine.BSF.4.21.0006010350390.985-100000@besplex.bde.org>
In-Reply-To: <20000531172817.2AFFC1CE1@overcee.netplex.com.au>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 31 May 2000, Peter Wemm wrote:

> Bruce Evans wrote:
> > >  open(PATH_DEV "rmt0", ...
> > 
> > This would break K&R support :-), and wouldn't work in most contexts
> > (the basename is normally from argv[]; for dump(8) it may be from the
> > environment).
> 
> How did I just *know* you were going to say that.  You should have said
> "break K&R support even more" - it's already pretty badly broken.

Troll food :-).  It's only slightly broken in sources that once supported
K&R.  E.g., in the part of dump(8) that handles _PATH_DEV:

Script started on Thu Jun  1 03:50:14 2000
ttyv2:bde@besplex:/usr/src/sbin/dump> make -k CC='bcc -G -Dconst=' dumprmt.o
bcc -G -Dconst= -O -pipe -DRDUMP -I/usr/src/sbin/dump/../../libexec/rlogind   -c /usr/src/sbin/dump/dumprmt.c
/usr/src/sbin/dump/dumprmt.c:366.9: error: errno undeclared
*** Error code 1 (continuing)
ttyv2:bde@besplex:/usr/src/sbin/dump> exit

Script done on Thu Jun  1 03:50:30 2000

Here the breakage is just a bug (someone fixed `extern int errno' by
including <errno.h>, but included it in the wrong place).

Bruce



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0006010350390.985-100000>