Date: Tue, 10 Mar 2015 07:27:03 -0600 From: Ian Lepore <ian@freebsd.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Thomas Skibo <ThomasSkibo@sbcglobal.net> Subject: Re: svn commit: r279828 - head/sys/dev/cadence Message-ID: <1425994023.33324.9.camel@freebsd.org> In-Reply-To: <20150310102525.GU17947@FreeBSD.org> References: <201503092239.t29MdxUo089384@svn.freebsd.org> <20150310102525.GU17947@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2015-03-10 at 13:25 +0300, Gleb Smirnoff wrote: > On Mon, Mar 09, 2015 at 10:39:59PM +0000, Ian Lepore wrote: > I> Author: ian > I> Date: Mon Mar 9 22:39:58 2015 > I> New Revision: 279828 > I> URL: https://svnweb.freebsd.org/changeset/base/279828 > I> > I> Log: > I> Use the new ifnet API. Also, allocate bus_dma_maps as needed instead of > I> pre-allocating them all at start-up. Also fix a bug in cgem_stop(); before, > I> it wasn't properly unloading dma maps due to a cut-and-paste error. > > Ian, the new ifnet API isn't the last word in ifnet API. :) > > Since you are already into that, I'd appreciate if you look > into projects/ifnet branch and convert cgem(4) to it. > > As examples, you can look at msk(4), bge(4), xl(4) and vtnet(4) > in the branch. > Hrm, I know nothing about the cgem driver and very little about ethernet drivers in general (despite having "written" one, mostly by cut and paste from working drivers). I was committing this on behalf of a non-committer contributor who maintains the Xilinx/Zynq arm code. I just noticed I forgot to add to the commit... Submitted by: Thomas Skibo I'll add him to the CC on this, in case he has time to work up a patchset for the projects/ifnet branch for you. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1425994023.33324.9.camel>