Date: Thu, 11 Jun 1998 13:50:40 +0800 From: Peter Wemm <peter@netplex.com.au> To: Julian Elischer <julian@whistle.com> Cc: Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.ORG, julian@FreeBSD.ORG Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vnops.c Message-ID: <199806110550.NAA10253@spinner.netplex.com.au> In-Reply-To: Your message of "Wed, 10 Jun 1998 22:27:37 MST." <Pine.BSF.3.95.980610222711.28634A-100000@current1.whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer wrote: > And your point is? While I'm slightly shocked to be agreeing with Bruce on a pedantic issue for a change :-), this really should have been done as two commits. The first should have been the backout of rev 1.46, the second should have been the other changes you made, including some sort of nutshell description of what was done. It's a heck of a lot easier to figure out what's going on that way. > On Thu, 11 Jun 1998, Bruce Evans wrote: > > > > Modified files: > > > sys/ufs/ffs ffs_vnops.c > > > Log: > > > Back out John's changes 1.45 -> 1.46 > > > Kirk confirms that the original semantic was what he wanted... > > > (well, a very slight difference) > > > May fix "dangling deps" panic with soft updates. > > > > > > Revision Changes Path > > > 1.50 +17 -21 src/sys/ufs/ffs/ffs_vnops.c > > > > A back out would have been +12 -17. > > > > It also seems to change the semantic to "wait for v_numoutput even in > > the soft updates case", and fix some style bugs, and break the > > optimization of using vfs_bio_awrite() instead of bawrite() for async > > writes of indirect blocks. > > > > Bruce > > > Cheers, -Peter -- Peter Wemm <peter@netplex.com.au> Netplex Consulting To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199806110550.NAA10253>